Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore 6.6.17 minimal reflections visuals #3456

Open
Geenz opened this issue Jan 22, 2025 · 0 comments
Open

Restore 6.6.17 minimal reflections visuals #3456

Geenz opened this issue Jan 22, 2025 · 0 comments
Assignees
@Geenz
Labels
enhancement New feature or request triage Flags issues that need to be triaged

Comments

@Geenz
Copy link
Contributor

Geenz commented Jan 22, 2025

With V7 we made substantial visual changes to water. This enhancement returns water to its previous state as it was with minimal reflections. Related comparisons: #3385

This only focuses on minimal reflections. The changes will also apply to when SSR is enabled, but that is not the focus.

Test Plan

  • Set the sky to Midday (Legacy)
  • Load 6.6.17 in a separate session
  • Compare water on Midday on 6.6.17 against Midday (Legacy) on V7
  • If the water is substantially different, fail
  • If the water looks the same, pass
@Geenz Geenz added enhancement New feature or request triage Flags issues that need to be triaged labels Jan 22, 2025
@Geenz Geenz self-assigned this Jan 22, 2025
@Geenz Geenz mentioned this issue Jan 30, 2025
Merged
Geenz added a commit that referenced this issue Jan 30, 2025
@Geenz
#3456 Water improvements to get us closer to 6.6.17 (#3490)
460e77c 
* A lot of tweaking for water.

* Get water much closer to 6.6.17.

This won't produce 1:1 results, but it should be much closer to where we once were.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geenz Geenz

Labels
enhancement New feature or request triage Flags issues that need to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Geenz