Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AIC/BIC information #340

Open
matzhaugen opened this issue Jan 31, 2023 · 1 comment
Open

Adding AIC/BIC information #340

matzhaugen opened this issue Jan 31, 2023 · 1 comment

Comments

@matzhaugen
Copy link

Is your feature request related to a problem? Please describe.
I'm not sure if this is 100% relevant to penalized cox regressions, but would it be useful to ad AIC and BIC metrics if cross-validation is inappropriate, e.g. due to data sparsity or for the reason of replicating other work?
In the same vein, a forward and backward selection method could also be employed (but that would probably go in another feature request).

Describe the solution you'd like
Add an AIC and BIC metric to the existing set of metrics.

Describe alternatives you've considered
As an alternative one could also compute the AIC/BIC oneself outside out this codebase.

References and existing implementations
An existing implementation of this can be found in the sciki learn package here

One reference paper that employs this with backward selection is here
https://doi.org/10.1016/j.jtcvs.2017.11.095

Again, not sure if the other criteria already implemented are perhaps more appropriate. If so, let me know.

@sebp
Copy link
Owner

sebp commented Feb 1, 2023

I agree that having AIC/BIC for CoxnetSurvivalAnalysis would be nice. If you want to work on it, please feel free to open a pull request.

Regarding, forward/backward selection, sklearn's SelectKBest could be helpful in that regard, but as you said, this is best discussed in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants