Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError: No fstab found #77

Open
Minionguyjpro opened this issue Jul 30, 2024 · 7 comments
Open

AssertionError: No fstab found #77

Minionguyjpro opened this issue Jul 30, 2024 · 7 comments

Comments

@Minionguyjpro
Copy link

Minionguyjpro commented Jul 30, 2024

Hello, I am getting this error after using dumpyara to dump my OTA package and then parse it to aospdtgen:

Android device tree generator
Version 1.1.1

[INFO] Figuring out partitions scheme
[WARNING] Unknown HAL type native
[INFO] Parsing build props and device info
[INFO] Parsing fstab
Traceback (most recent call last):
  File "/home/minionguyjpro/.local/bin/aospdtgen", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/minionguyjpro/.local/lib/python3.12/site-packages/aospdtgen/main.py", line 31, in main
    dump = DeviceTree(args.dump_path)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/minionguyjpro/.local/lib/python3.12/site-packages/aospdtgen/device_tree.py", line 53, in __init__
    assert fstabs, "No fstab found"
           ^^^^^^
AssertionError: No fstab found

The path is valid, although I don't see a seperate fstab although I do see them in the ramdisks but it's called fstab.samsungexynos7870 (referring to my SoC). Maybe renaming to fstab would work?

Original firmware (.tar.md5 is inside of the ZIP file)
boot.img
recovery.img

@Minionguyjpro
Copy link
Author

Found a recovery.fstab which is also pointed to in the all_files.txt file, not sure why aospdtgen cannot find it.

@Igorpetinik
Copy link

I can try create pull request with using ALL fstab files. just wait.

@Igorpetinik
Copy link

oops, i can't

@rosbeef
Copy link

rosbeef commented Aug 19, 2024

not sure why aospdtgen cannot find it

maybe because script search for file starting with fstab. not ending with .fstab ?

if (is_relative_to(file.relative_to(self.vendor.path), "etc") and file.name.startswith("fstab."))

@magnoliy
Copy link

got the same issue. i have fstab.samsungexynos7570, recovery.fstab and another fstab.samsungexynos7570 in my dumpyara dump. has anyone fixed it? or is the dump folder not correctly setup?

@magnoliy
Copy link

fixed it by copying the fstab.____ from /boot/ramdisk to /system/vendor/etc

@Minionguyjpro
Copy link
Author

Minionguyjpro commented Aug 28, 2024

fixed it by copying the fstab.____ from /boot/ramdisk to /system/vendor/etc

Worked! I copied it to system/etc though, which also worked. I think it has to be in the system partition somewhere to function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants