Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sleep for schema agreement - since we now have raft with consistent schema management #9660

Open
roydahan opened this issue Jan 6, 2025 · 3 comments · May be fixed by #9792
Open

Remove sleep for schema agreement - since we now have raft with consistent schema management #9660

roydahan opened this issue Jan 6, 2025 · 3 comments · May be fixed by #9792
Assignees
@roydahan

Comments

@roydahan
Copy link
Contributor

roydahan commented Jan 6, 2025

No description provided.

@roydahan roydahan mentioned this issue Jan 6, 2025
Closed
@mykaul mykaul marked this as a duplicate of #9695 Jan 8, 2025
@temichus temichus mentioned this issue Jan 9, 2025
Closed
@temichus
Copy link
Contributor

temichus commented Jan 9, 2025

@roydahan should I put it into my backlog? Or you can handle it.
scylladb/scylladb#5235 (comment)

cc @mykaul

@mykaul
Copy link
Contributor

mykaul commented Jan 9, 2025

@roydahan should I put it into my backlog? Or you can handle it. scylladb/scylladb#5235 (comment)

cc @mykaul

I can handle it as well, I just want (1) the relevant people from the Raft testing team to be aware, agree and (2) not do it while everything's flaky in CI and lastly (3) ensure it's OK and won't introduce more flakiness.

@roydahan
Copy link
Contributor Author

roydahan commented Jan 9, 2025

No need for backlog.
I'm handling this, basically it requires to retest rolling upgrades with this change to make sure it doesn't break anything.
I wanted first to see that it passes when the issue is closed.

@mykaul mykaul marked this as a duplicate of #9662 Jan 9, 2025
roydahan added a commit to roydahan/scylla-cluster-tests that referenced this issue Jan 13, 2025
@roydahan
improvement(fill_db_data): Remove 30s sleep of waiting for schema agr…
8975202 
…eement

Now that all of our recent releases contains raft with consistent scehma
management, this sleep isn't needed anymore.

Test: rolling upgrades.

Fixes: scylladb#9660
@roydahan roydahan linked a pull request Jan 13, 2025 that will close this issue
Draft
3 tasks
roydahan added a commit to roydahan/scylla-cluster-tests that referenced this issue Jan 20, 2025
@roydahan
improvement(fill_db_data): Remove 30s sleep of waiting for schema agr…
82b5ae2 
…eement

Now that all of our recent releases contains raft with consistent scehma
management, this sleep isn't needed anymore.

Test: rolling upgrades.

Fixes: scylladb#9660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roydahan roydahan

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@temichus @mykaul @roydahan