Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support numpy 2.0 #2842

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: support numpy 2.0 #2842

wants to merge 12 commits into from

Conversation

martinkim0
Copy link
Contributor

closes #2390

@martinkim0 martinkim0 added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Jun 17, 2024
@martinkim0
Copy link
Contributor Author

martinkim0 commented Jun 17, 2024

this is currently blocked by the following upstream dependencies not supporting numpy 2.0:

  • loompy
  • pymde

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (30337b7) to head (302ae54).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2842      +/-   ##
==========================================
- Coverage   85.22%   85.21%   -0.01%     
==========================================
  Files         166      166              
  Lines       14229    14228       -1     
==========================================
- Hits        12126    12125       -1     
  Misses       2103     2103              
Files Coverage Δ
src/scvi/train/_callbacks.py 86.02% <25.00%> (ø)

... and 2 files with indirect coverage changes

@martinkim0 martinkim0 removed the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Jun 20, 2024
@martinkim0 martinkim0 added the on-merge: backport to 1.1.x on-merge: backport to 1.1.x label Jun 27, 2024
@canergen canergen removed the on-merge: backport to 1.1.x on-merge: backport to 1.1.x label Jul 26, 2024
@Zethson
Copy link
Member

Zethson commented Oct 3, 2024

The last release of pymde was in 2022 and the last commit a year ago. I am not sure how sustainable it is to keep depending on it...

@canergen
Copy link
Member

canergen commented Oct 8, 2024

Agreed seems like lowly maintained. I am then also against keeping it optional and we should just highlight it in some tutorial. With RAPIDS UMAP the need is also much smaller now. Loompy still doesn't support >2.0 based on a quick check though. So let's wait until they have figured things out and drop pyMDE then.

@canergen
Copy link
Member

canergen commented Oct 8, 2024

@ori-kron-wis Can you switch loom to anndata.io (https://anndata.readthedocs.io/en/latest/generated/anndata.io.read_loom.html)? I assume we then support numpy>2.0. We should for now make pyMDE optional and set an optional requirement to numpy<2.0 for this dependency. We should drop it for the 1.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for NumPy 2
4 participants