Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone definition purely using CDR3 sequence #507

Closed
zktuong opened this issue Apr 15, 2024 · 3 comments · Fixed by #470
Closed

clone definition purely using CDR3 sequence #507

zktuong opened this issue Apr 15, 2024 · 3 comments · Fixed by #470

Comments

@zktuong
Copy link
Contributor

zktuong commented Apr 15, 2024

Hi @grst,

I've been asked recently to create clonotype definitions purely using the identical/similar CDR3 sequence (and not considering any V/J gene information) and wanted to check with you whether this could be something useful to implement here as well? As far as i can tell, there's currently only same_v_gene but i guess we can add another same_j_gene?

@grst
Copy link
Collaborator

grst commented Apr 15, 2024

Hi @zktuong,

actually, the J gene is currently not considered at all.
But actually, afaik @felixpetschko is working on having a same_j_gene feature as part of the optimized clonotype calling in #470.

@grst
Copy link
Collaborator

grst commented Aug 15, 2024

@zktuong, could d_call/c_call also be relevant?

Mostly asking because I'm debating the interface with @felixpetschko in #470 (comment)

We could have either

same_v_gene: bool = True,
same_j_gene: bool = True

or something like

same_chain_attr: Sequence[str] = ["v_call", "j_call"]

The latter would be generic and work for any field that is chain-specific (rather than cell-specific), be it genes or something else. Not entirely sure though if there's even a use-case for that.

@zktuong
Copy link
Contributor Author

zktuong commented Aug 18, 2024

d/c calls aren't relevant imo.

i think the first option is more intuitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants