Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable supplying arbitrary tags #4

Open
jim80net opened this issue Feb 25, 2020 · 3 comments
Open

Enable supplying arbitrary tags #4

jim80net opened this issue Feb 25, 2020 · 3 comments

Comments

@jim80net
Copy link
Contributor

jim80net commented Feb 25, 2020

I want to supply a tags parameter with an arbitrary map of tags, potentially eliminating the hard coded Namespace and Env parameters. So that I don't have to be limited by only env and namespace.

Given we've already an expectation to support these parameters, perhaps in implementation we can simply add tags, and deprecate the namespace and env parameters until users have converged on the new mechanism.

@houqp
Copy link
Contributor

houqp commented Feb 25, 2020

I like the idea of supporting arbitrary map of tags as well. Only question I have is if we remove special tags like namespace and env, how should we generate unique name for resources. Adding all the tags to the name can easily cause errors like exceeding max length constraint.

Perhaps a middle ground is to support arbitrary map of tags but keep namespace and env as special tags that will be used for constructing unique ids and names?

@Art3mK
Copy link
Contributor

Art3mK commented Jun 30, 2020

btw, what is that namespace tag? I've never used datadog before, but can't find any namespace tag mention in their documentation, why it's special? What it's used for? To distinguish different AWS accounts and their metrics?

and uniq names could be generated using random provider in tf.

@houqp
Copy link
Contributor

houqp commented Jul 2, 2020

@Art3mK this is for human readable prefixes, we also use it to tag resources for each individual teams since each team has its own AWS account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants