Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video.upload loads entire video file into memory #64

Open
thenewguy opened this issue Dec 30, 2010 · 0 comments
Open

video.upload loads entire video file into memory #64

thenewguy opened this issue Dec 30, 2010 · 0 comments

Comments

@thenewguy
Copy link

@https://github.com/sciyoshi/pyfacebook/blob/master/facebook/__init__.py#L1138

It appears that VideoProxy.upload() was copied from PhotosProxy.upload(). The upload method loads the entire file into memory. Seeing as to how high quality videos are quite large, this should be reworked in the VideoProxy for sure and arguably PhotosProxy as well for the sake of shared hosting or situations where memory is limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant