-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU support for PFT tracking #901
Comments
PFT Papa here, CMC (and ACT) can both be used without PFT, but both require the
|
Can we have a more representative name? |
A fair name would be A better solution would be to enable CMC and ACT in |
It could be supported, we just need to take the time to implement it. I guess an easy first step could be to add the option to disable PFT for the PFT tracking (which is counterintuitive, but I agree changing it would also be confusing). Then in a further PR we could add CMC gpu and build on top of it for future features such as ACT and PFT. |
Yesterday I closed without merging PR #720, where I added continuous maps criterion for GPU tracking. The modules and script have changed so much since I have made this PR that it will be easier to just start from scratch again.
However, I am wondering where CMC GPU should go. Now,
scil_tracking_local
supports both CPU and GPU so I guess the most natural place to put CMC would be inscil_tracking_pft
with a--use_gpu
flag. However, it is a bit weird that the option--use_gpu
would actually disable particle filtering (as it is not implemented yet) for a script which has PFT in its name.Here is the idea François and I came up with:
--use_gpu
disables particle filtering.Maybe some help from le papa de PFT @gabknight ?
@frheault Disabling PF prior to adding the GPU stuff could be a good task for a new student 🤔
@arnaudbore @EmmaRenauld Any comments/ideas?
The text was updated successfully, but these errors were encountered: