Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current nf-core and nf-test limitations #136

Open
2 tasks
AlexVCaron opened this issue Apr 25, 2024 · 5 comments
Open
2 tasks

Current nf-core and nf-test limitations #136

AlexVCaron opened this issue Apr 25, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@AlexVCaron
Copy link
Collaborator

There is a few problems / hurdles / efficiency issues using nf-core right now. Let's use this issue to list them and discuss.

  • git-remote and branch in commands to target nf-scil
  • nf-test stacktrace is hard to understand, not human readable
@AlexVCaron AlexVCaron added the bug Something isn't working label Apr 25, 2024
@AlexVCaron AlexVCaron self-assigned this Apr 25, 2024
@arnaudbore
Copy link
Contributor

  • lint fail when using params.scilpy_version

@arnaudbore
Copy link
Contributor

generic tag for docker release

@AlexVCaron
Copy link
Collaborator Author

Talking points on NF-TEST

tests infrastructure (asserts and data managers) for medical imaging

  • there is an assertion for gzipped files, need to test if it solves md5 problems
  • if we want to add assertions on image data (msse, variance, ect.), everything in nf-test for us !
    • plugin framework
    • libs can be placed in test directories, they hotpatch nf-test

@AlexVCaron
Copy link
Collaborator Author

Talking points on multiqc

  • it's an aggregator, can do some population-wise analysis, less powerful subject wise
  • uses template defined for bio-informatics, which are default
    • we'd need to create templates for generic Neuroimaging QC
      • not sure, we're not there yet
      • maybe the template can be nothing more than an image viewer ?
        • anything else plotted or analyzed with stats integrates ?
  • QC measures need to be generated per subjects priorhand
  • there is a plugin/extension infrastructure to hotpatch multiqc with our stuff

@AlexVCaron
Copy link
Collaborator Author

Talking points on NF-CORE

how to make the CLI lighter for custom module/subworkflow repos

  • dependency resolve is a no (Paolo DiTomasso veto), better have one thing used only, if it is updated somewhere, should be updated everywhere
    • modules and subworkflows can have the same name, in different org_path, if needed
  • Lean down CLI for remote component repositories nf-core/tools#2993
    • right now, best way is through environment variables, all opts have a NFCORE_ equivalent
    • looking up what is standard in python, think it's using XDG_CONFIG_HOME

metadata and usage for task.ext options

  • task.ext are bout to disappear, should be translated as inputs
    • REQUIRE optional inputs to be usable, else module calls get monstruous

integration of nf-scil in nf-core

  • We now have a Special Interest Group (SIG) in nf-core (link to come), where we'll discuss how we integrate
    • the idea is to have our modules and subworkflows in a groups aside nf-core
      • located in the modules and subworkflows directories, aside of the nf-core directory
    • First thing is to PR a module and subworkflow to nf-core to create the directories and framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants