Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Year search facet with date slider is missing #53

Closed
1 of 2 tasks
brijmcla opened this issue Aug 29, 2024 · 3 comments
Closed
1 of 2 tasks

Year search facet with date slider is missing #53

brijmcla opened this issue Aug 29, 2024 · 3 comments
Assignees
@kirkkwang

Comments

@brijmcla
Copy link
Collaborator

brijmcla commented Aug 29, 2024 •
edited
Loading

Story

Acceptance Criteria

  • Year search facet displays and functions
  • Date slider is present within Year search facet

Screenshots / Video

year_facet

![year_facet](https://github.com/user-attachments/assets/790e7fae-3d76-4625-ba3d-840c80ae372a)

Testing Instructions and Sample Files

  • Click the search button on the homepage
  • Check if Year facet shows up on the left side of the screen
  • Click the Year facet button to ensure that the date slider also shows up (⚠️ See notes)

Notes

⚠️ The date slider does not function at the moment, there seems to be an incompatibility with Rails 7/Blacklight 8.
See:
@kirkkwang kirkkwang self-assigned this Aug 29, 2024
kirkkwang added a commit that referenced this issue Aug 29, 2024
@kirkkwang
💄 Hiding a lot of the UI from range facet
f02ec74 
It seems that Blacklight Range Limit and Rails 7/Blacklight 8 don't work
well together.  The javascript does not seem to be working properly.
I've hidden the UI for the parts that don't work for now borrowing from
Standford's Arclight solution.

Ref:
- #53
- projectblacklight/blacklight_range_limit#236
- sul-dlss/stanford-arclight#529
This was referenced Aug 29, 2024
Merged
Merged
@kirkkwang
Copy link

✅ Passes QA with the caveat that the slider is not compatible with this version of Arclight

Image

@brijmcla
Copy link
Collaborator Author

brijmcla commented Sep 4, 2024

I wanted to confirm on the ticket that I agreed to exclude the date slider since it was not compatible with Arclight and wasn't a very helpful function to begin with.

@brijmcla
Copy link
Collaborator Author

brijmcla commented Sep 4, 2024

Acceptance criteria has been met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
None yet
Projects
indiana-arclight
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kirkkwang @brijmcla