-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with tribuo as a transitive dependency #1
Comments
I fully agree that we need docu.
Each model type needs a different dependency. |
I suggest to identify and add "fixed" the core dependencies, for sure. |
The imports are done by tech.ml.dataset.tribuo
The code here uses:
|
I added the needed "core" dependencies to the deps in this branch: This still does require that a "user" of scicloj.ml.tribuo needs to add the deps of the used model, as I did in the 'test': Line 19 in 6f2bae5
So we needed to document this in here. |
Which model is in which "component" and therefore "in which deps", is fully documented in this table: |
@kiramclean and then you can try it. |
This makes sense. It's cool that they split the deps out into smaller jars that can be included individually to minimize the final package size, but sad that it creates this downstream problem for libraries that consume tribuo. Anyway this seems like a reasonable solution. We should update the readme and include a link that list to make it clear which libs need to be included for which models. I can also make a note of that in all the upcoming tutorials/book chapters etc. Thanks for looking into this! I think Tribuo is a good solution for ML models going forward.. seems to work smoothly and across platforms well. |
When
scicloj.ml.tribuo
is included as a dependency in another project, starting a REPL fails with the following error:I believe this is due to the lack of support for BOM deps in tools.deps. I don't know if leiningen also has this issue. One possible workaround (insofar as this counts as one at all..) would just be to update the readme of this project to mention that one has to include
tribuo-all
explicitly in their owndeps.edn
for this library to work.An actual solution would be to track down all of the components of tribuo-all that are (or could possibly be) used give the supported tribuo features in this library and list them all explicitly as deps.
I believe it would be worth at least doing the readme update, since the error message is somewhat misleading if you don't already know what the underlying issue is.
The text was updated successfully, but these errors were encountered: