-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement result export #13
Comments
Initial functionality implemented in 139d682. Still need to implement the logic for the partial annotations:
|
Would be great to know why not/ if there is something we could do to make the current API hooks better, or if there are different hooks that you would have preferred. I'll note that right now there is no hook Feedback welcome, you're one of our first real world test cases!! |
@sofroniewn
Re 1.: I will give a more detailed summary of what went wrong tomorrow (it's a bit late in Germany already ;)). But in general having a full example for the Re 2. Yes, |
Ok, I can demonstrate that I try to save the labels layer as h5: I would have expected that my hook implementation is picked up for this case. |
Ok good to know you struggled with
Hmm ok, here I would have hoped that the Anyway, whatever you choose if fine for now, but this is helpful for us as we think about the plugin interface and workflows |
I actually see this more as a keyboard shortcut issue: @constantinpape would be fine if ctrl-S mapped to Save All Layers, rather than Save Selected Layer(s). He could then write a I'd also say this is a slightly unusual plugin scenario (it's more of a sub-app, as has already been pointed out). In most cases, i don't think we're going to want plugins to be able to completely own the |
just to be clear here, it's this line that is the problem. Something like this should work # NOTE this doesn't work yet, but also doesn'make much sense in this context
@napari_hook_implementation
def napari_get_writer(path, layers):
# make sure there is at least one labels
if any(l == 'labels' for l in layers):
return save_labels ...and then you need a |
Yes, this makes sense.
I also agree. I think the clean way would be to redesign this project so that it is a proper plugin, don't hard-codes the layer names but offers the extra functionality as layer decorators. I don't have time for this now, and I also don't think napari plugins support all we need for this approach yet, but I would be very interested to keep working on this once things calm down. |
I am not sure. I changed to your suggestion now: But it still doesn't work. Also the |
We will not do the partial results functionality in the app, but rather as post-processing. |
See how we can use the writer io hook to export the annotation results.
The text was updated successfully, but these errors were encountered: