Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize QC #125

Closed
constantinpape opened this issue May 14, 2020 · 5 comments
Closed

Finalize QC #125

constantinpape opened this issue May 14, 2020 · 5 comments
Labels
high priority Should be done before we finalize the repo for the preprint

Comments

@constantinpape
Copy link
Contributor

I just discussed with @tischi: we should finalize the values for the QC that is currently implemented:

  • cell sizes: for this, @tischi will plot histograms for a large enough samples of cells; we try to estimate a threshold based on this, but will double check if it makes sense by exporting masks that show all cells that would break it and then see how these cells actually look.
  • nucleus sizes: as discussed it would make a lot of sense to filter nucleus sizes to get rid of small and large dirt. This is implemented already, but not activated yet. For this, @metavibor suggested values already. I think we can also just set a lower and upper radius for and compute this analytically, because the nuclei are fairly uniform in size. I will try this later and then see how this agrees with the values proposed by vibor.
  • fraction of control cells per well: I think this is an important QC measure, but I don't have a good idea how to set it. @metavibor, @tischi do you have any more insights here?
@constantinpape constantinpape added the high priority Should be done before we finalize the repo for the preprint label May 14, 2020
@metavibor
Copy link

fraction of control cells per well: I think this is an important QC measure, but I don't have a good idea how to set it. @metavibor, @tischi do you have any more insights here?

I would go the same way as you described above. Lets plot histograms of control cell numbers per well and see what is the lowest number we get and than check those wells and the values we get in them to see if something is weird... that should give us a clue of the good value there

@constantinpape
Copy link
Contributor Author

I would go the same way as you described above. Lets plot histograms of control cell numbers per well and see what is the lowest number we get and than check those wells and the values we get in them to see if something is weird... that should give us a clue of the good value there

Ok, sounds good.
@tischi you should have all the information for this in the tables.

@tischi
Copy link

tischi commented May 15, 2020

I'll be making one issue per QC in the antibody-issues repo and post the plots there.
I also made a new issue tag "quality control" for this.

@tischi
Copy link

tischi commented May 15, 2020

@constantinpape
Copy link
Contributor Author

This is done now, here are the criteria we will use for the preprint:

CELL_OUTLIER_CRITERIA = {'max_cell_size': 12500,
                                                   'min_cell_size': 250,
                                                   'min_nucleus_size': 125,
                                                   'max_nucleus_size': 1000}

IMAGE_OUTLIER_CRITERIA = {'max_number_cells': 1000,
                                                     'min_number_cells': 10} 

WELL_OUTLIER_CRITERIA = {'min_number_control_cells': 100,
                                                   'min_fraction_of_control_cells': None,
                                                   'check_ratios': True}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Should be done before we finalize the repo for the preprint
Projects
None yet
Development

No branches or pull requests

3 participants