Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming convention for changeset (discussion) #64

Open
rin-st opened this issue Jun 19, 2024 · 1 comment
Open

Naming convention for changeset (discussion) #64

rin-st opened this issue Jun 19, 2024 · 1 comment

Comments

@rin-st
Copy link
Member

rin-st commented Jun 19, 2024

What do you think about naming convention for changesets? Because currently, it's a bit chaotic how we write it https://github.com/scaffold-eth/create-eth/releases

I think it would be good if we write it that way
<scope>: <what was changed>

Possible scope's: cli, hardhat, foundry, next, external-extensions, curated-extensions, gh-actions, general? etc. Do we need to capitalize?

For example
cli: fix listr spamming
curated-extensions: added eip-712

Or maybe just as conventional commits? What do you think?

@technophile-04
Copy link
Collaborator

Ohh yeah 100% agree! Love the scope idea too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants