Skip to content
This repository has been archived by the owner on Nov 15, 2020. It is now read-only.

unexpected syntax changes #34

Open
PavelAlennikov opened this issue Apr 17, 2018 · 4 comments
Open

unexpected syntax changes #34

PavelAlennikov opened this issue Apr 17, 2018 · 4 comments

Comments

@PavelAlennikov
Copy link
Contributor

now we use () instead of "" when we want to specify page where the request will be sent.
this is different from page-factory syntax.

@0I0u3uk
Copy link
Contributor

0I0u3uk commented Apr 19, 2018

@clicman @kosteman what do you think? LGTM

@kosteman
Copy link
Contributor

But this is logical. @ApiAction != @PageEntry. Maybe wrapped by @ApiAction class is a bit like Page Object, but it represents the execution of a specific request, which is an action.

@PavelAlennikov
Copy link
Contributor Author

I think that actual realisation doesnt matter for user. I expect to write params in "" not in ().

@clicman
Copy link
Contributor

clicman commented Apr 19, 2018

Since ApiEntry was designed by PageObject fashion. it should concern the same rules on its syntax patterns

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants