Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with "get_stats_by_list" method in class "card" #315

Open
AlexeyGurtovenko opened this issue Aug 2, 2020 · 2 comments
Open

Issue with "get_stats_by_list" method in class "card" #315

AlexeyGurtovenko opened this issue Aug 2, 2020 · 2 comments

Comments

@AlexeyGurtovenko
Copy link

AlexeyGurtovenko commented Aug 2, 2020 •
edited
Loading

There is a typo in line: "if source_list_id not in stats_by_list or not destination_list["id"] not in stats_by_list:" in "get_stats_by_list" method.

The line should be chaged to: "if source_list_id not in stats_by_list or destination_list["id"] not in stats_by_list:"

There is no need to have NOT before "destination_list["id"]".
@ddanielvaz
Copy link
Contributor

There is also a problem in computing the time of card has been in each List.

ddanielvaz added a commit to ddanielvaz/py-trello that referenced this issue Jun 18, 2021
@ddanielvaz
Fixing typo reported in sarumont#315.
9859853 
Fixing identation when checking last_list (comment was idented correctly, but code not).
Fixing the calculation of the time that card has been on a list, correcting last_action_datetime update value by putting it before if/continue statement.
@ddanielvaz ddanielvaz mentioned this issue Jun 18, 2021
Closed
@ddanielvaz
Copy link
Contributor

#339

sarumont pushed a commit that referenced this issue Jan 26, 2023
@ddanielvaz @sarumont
Fixing typo reported in #315.
c7df55a 
Fixing identation when checking last_list (comment was idented correctly, but code not).
Fixing the calculation of the time that card has been on a list, correcting last_action_datetime update value by putting it before if/continue statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddanielvaz @AlexeyGurtovenko