Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when multiple PacBio files are given #90

Merged
merged 6 commits into from
May 24, 2024
Merged

Fix when multiple PacBio files are given #90

merged 6 commits into from
May 24, 2024

Conversation

muffato
Copy link
Member

@muffato muffato commented May 23, 2024

The bug occurred when there were multiple PacBio files. SAMTOOLS_FILTER was getting unsynchronised data from ch_reads and PACBIO_FILTER.out.list. The fix is to pair elements in those two channels before feeding SAMTOOLS_FILTER.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Not truly original PacBio files because they've been subsetted, but good enough for testing.
@muffato muffato changed the title Pacbio fix Fix when multiple PacBio files are given May 23, 2024
@muffato muffato self-assigned this May 23, 2024
@muffato muffato added the bug Something isn't working label May 23, 2024
@muffato muffato requested a review from gq1 May 23, 2024 21:22
CHANGELOG.md Outdated Show resolved Hide resolved
@gq1
Copy link
Member

gq1 commented May 24, 2024

Looks good for me.
But we need to fix the same problems in variantcalling pipeline.
sanger-tol/variantcalling#77

@gq1
Copy link
Member

gq1 commented May 24, 2024

Merging to the main branch should be blocked by CI but not actually.
We should update the master branch to main in this CI:

branches: [master]

@muffato
Copy link
Member Author

muffato commented May 24, 2024

Merging to the main branch should be blocked by CI but not actually. We should update the master branch to main in this CI:

branches: [master]

Interesting find. I can see that the expected way is to name the branch patch.

I added a commit to this PR to fix master/main in .github/workflows/branch.yml

@muffato muffato merged commit 91a9d07 into main May 24, 2024
6 checks passed
@muffato muffato deleted the pacbio_fix branch May 24, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants