Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user control of output format and compression #107

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

tkchafin
Copy link
Contributor

Addresses #64

  • Adds --outfmt option
  • Adds --compression option
  • Updates documentation

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tkchafin tkchafin requested a review from SandraBabirye August 14, 2024 16:15
@tkchafin tkchafin linked an issue Aug 14, 2024 that may be closed by this pull request
@tkchafin
Copy link
Contributor Author

Hi @SandraBabirye I have pushed some changes hopefully addressing issue #64 for the readmapping pipeline.

I thought this might be a good chance to try out doing a code review! Could you test that the pipeline works and generates the correct outputs for each combination of the new arguments:

nextflow run main.nf -profile test,docker --outfmt bam,cram --compression none 
nextflow run main.nf -profile test,docker --outfmt bam,cram --compression cram 
nextflow run main.nf -profile test,docker --outfmt bam
nextflow run main.nf -profile test,docker --outfmt cram

And take a look at my implementation please? There should be an "add review" button in green in the top right

Copy link

@SandraBabirye SandraBabirye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this PR! I've carefully reviewed the changes, and everything looks well-implemented.

@tkchafin tkchafin merged commit 1b91ed8 into sanger-tol:dev Aug 19, 2024
8 checks passed
@tkchafin tkchafin deleted the output_options branch August 19, 2024 13:37
@tkchafin tkchafin mentioned this pull request Aug 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiple output options
2 participants