Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setupvm and upgradevm should require confirmation #258

Open
ocdtrekkie opened this issue Feb 7, 2020 · 0 comments
Open

setupvm and upgradevm should require confirmation #258

ocdtrekkie opened this issue Feb 7, 2020 · 0 comments

Comments

@ocdtrekkie
Copy link
Collaborator

This is particularly egregious with setupvm, but I'd like to fix it for both. These commands overwrite existing app packaging files without any confirmation. In the case of setupvm it is basically a reset of your packaging efforts, upgradevm it is just going to force you to fix your app build for the latest VM.

Either way, we should probably put a quick "are you sure?" in here. We may also need to look at a flag or environment variable to skip these confirmations. While nobody is using it AFAIK, vagrant-spk auto is a thing that exists in the code that @paulproteus was building, and other situations where people have scripted calling setupvm may exist. (Nobody is currently scripting calling upgradevm yet because it doesn't exist yet.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant