Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when overwriting a configuration rather than just adding new entries #5

Open
magnus-ISU opened this issue Jan 3, 2022 · 0 comments · May be fixed by #8
Open

Warn when overwriting a configuration rather than just adding new entries #5

magnus-ISU opened this issue Jan 3, 2022 · 0 comments · May be fixed by #8

Comments

@magnus-ISU
Copy link

I'm thinking that if any exist, it should create a popup listing all the configurations that will be overwritten (for example, if brave is set to open x-scheme-handler/https and then I set firefox for all defaults, then it should show up

Warning: Some previously-configured settings will be overwritten:
Brave currently opens x-scheme-handler/http
Brave currently opens x-scheme-handler/https

[ Overwrite settings ]   [ Only add non-conflicting rules ]   [ Cancel all changes ]

Those button names suck, the middle one especially is way too long (but I would rather err on the verbose side to the non-verbose ok vs cancel crappy design you see everywhere), if anyone has suggestions to shorten them.

I will probably open a pull request here in a couple days (or maybe hours idk, shouldn't be too hard to do I think)

@magnus-ISU magnus-ISU changed the title Warn when overwriting a configuration from another app. Warn when overwriting a configuration rather than just adding new entries Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant