From abdea053af62d36cd4bbb13bb55f6c21c696bee2 Mon Sep 17 00:00:00 2001 From: Sandro Figo Date: Sat, 20 May 2023 16:35:02 +0200 Subject: [PATCH 1/5] Remove unused code --- VoxReader/Helper.cs | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/VoxReader/Helper.cs b/VoxReader/Helper.cs index f06b123..c48bf61 100644 --- a/VoxReader/Helper.cs +++ b/VoxReader/Helper.cs @@ -31,14 +31,6 @@ public static IEnumerable ExtractModels(IChunk mainChunk, IPalette palet var transformNodeChunks = mainChunk.GetChildren(); var groupNodeChunks = mainChunk.GetChildren(); - var allNodes = new Dictionary(); - foreach (ITransformNodeChunk t in transformNodeChunks) - allNodes.Add(t.NodeId, t); - foreach (IGroupNodeChunk g in groupNodeChunks) - allNodes.Add(g.NodeId, g); - foreach (IShapeNodeChunk s in shapeNodeChunks) - allNodes.Add(s.NodeId, s); - var transformNodesThatHaveAShapeNode = new Dictionary(); foreach (ITransformNodeChunk transformNodeChunk in transformNodeChunks) { @@ -67,7 +59,7 @@ public static IEnumerable ExtractModels(IChunk mainChunk, IPalette palet yield return new Model(0, null, new Vector3(), size, voxels, false); yield break; } - + var processedModelIds = new HashSet(); foreach (var keyValuePair in transformNodesThatHaveAShapeNode) From a29d2cc877f35a19c11df44e2afe4dbaff29b704 Mon Sep 17 00:00:00 2001 From: Sandro Figo Date: Sat, 20 May 2023 16:37:27 +0200 Subject: [PATCH 2/5] Update version string for GitHub release name --- build/Build.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/Build.cs b/build/Build.cs index 79e31a2..3eee41e 100644 --- a/build/Build.cs +++ b/build/Build.cs @@ -179,7 +179,7 @@ class Build : NukeBuild var newRelease = new NewRelease($"v{version}") { Draft = true, - Name = version.ToString(), + Name = $"v{version}", Prerelease = version.IsPrerelease, Body = changelog }; From efc612a42a2857a4eff62f2e3a3fe8f566664429 Mon Sep 17 00:00:00 2001 From: Sandro Figo Date: Sat, 20 May 2023 16:44:33 +0200 Subject: [PATCH 3/5] Update CHANGELOG --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a578506..b57f030 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). --> +## [4.1.1] - 2023-05-20 + +### Changed + +- Removed redundant code when parsing models + ## [4.1.0] - 2023-05-20 ### Added From b3ef0e71f7a9499660d3154b886c50884d398f8c Mon Sep 17 00:00:00 2001 From: Sandro Figo Date: Sat, 20 May 2023 16:45:27 +0200 Subject: [PATCH 4/5] Update package file --- VoxReader/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VoxReader/package.json b/VoxReader/package.json index c941dac..dd4266e 100644 --- a/VoxReader/package.json +++ b/VoxReader/package.json @@ -1,6 +1,6 @@ { "name": "com.sandrofigo.voxreader", - "version": "4.1.0", + "version": "4.1.1", "displayName": "VoxReader", "description": "A C# library to read .vox files created with MagicaVoxel", "documentationUrl": "https://github.com/sandrofigo/VoxReader", From 52218f5c7e46e75c803c9d44101524d821ad3f69 Mon Sep 17 00:00:00 2001 From: Sandro Figo Date: Sat, 20 May 2023 16:50:58 +0200 Subject: [PATCH 5/5] Update CHANGELOG --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b57f030..ba4e81d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed -- Removed redundant code when parsing models +- Removed unused code when parsing models ## [4.1.0] - 2023-05-20