Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saturate (np.clip) unstructured controller? #282

Closed
ryancoe opened this issue Oct 23, 2023 · 1 comment
Closed

Saturate (np.clip) unstructured controller? #282

ryancoe opened this issue Oct 23, 2023 · 1 comment

Comments

@ryancoe
Copy link
Collaborator

ryancoe commented Oct 23, 2023

In reviewing #273, I noticed that we could actually saturate controller_unstructured the same way @cmichelenstrofer did for the PID controllers using np.clip. This would, in theory, produce the same result as a constraint applied to the optimization solution. However (as pointed out by @cmichelenstrofer) you would sort of lose information, in that the solution's Fourier components would not produce the saturated signal (because the np.clip operation is done on the time series during the solution process). @cmichelenstrofer and I therefore think this isn't a good idea, but I wanted to post it here for discussion and then close if appropriate.

@ryancoe
Copy link
Collaborator Author

ryancoe commented Oct 26, 2023

@cmichelenstrofer - points out that capturing saturation nonlinearities would be less computationally expensive using np.clip (you would not need to have all the harmonics in your frequency array).

However, we generally feel that this is a bit of a dangerous thing, because it makes it easy to make mistakes with the post-processing. Therefore closing for now.

@ryancoe ryancoe closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant