Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to check 'is_applicable' for known_memberships in linear_algebra and quantum algebra packages #320

Open
wwitzel opened this issue Feb 10, 2024 · 1 comment
Assignees
Labels

Comments

@wwitzel
Copy link
Collaborator

wwitzel commented Feb 10, 2024

InClass.yield_known_memberships does this properly where it checks 'is_applicable'. However, this doesn't appear done properly for yield_known_hilbert_spaces in the linear_algebra package or when using MatrixSpace.known_memberships in qmult.py. This can cause funny behavior when assumptions change. There may be other places where this is done incorrectly.

@wwitzel
Copy link
Collaborator Author

wwitzel commented Mar 31, 2024

As an addendum to this Issue, I'd like to like to add further InClass.conclude (and thereby InSet.conclude) automation, checking to see if the element has a "readily_provable_membership" method. If so, and if it returns True when given the domain for the membership we are trying to prove in "conclude", than call the element's "deduce_membership" method, letting the element handle things. Other automation works from the domain side, but sometimes it is better to handle it on the element side.

wwitzel added a commit that referenced this issue Apr 6, 2024
as well as the domain side via 'readily_provable_membership', if
the element has this attribute, and 'deduce_membership'.  This is
the addendum for Issue #320.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant