Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design for PolygonFilter #18

Open
flavour opened this issue Jul 6, 2017 · 7 comments
Open

Design for PolygonFilter #18

flavour opened this issue Jul 6, 2017 · 7 comments
Assignees

Comments

@flavour
Copy link
Member

flavour commented Jul 6, 2017

Implement the design for the Polygon Filter:
https://www.figma.com/file/ayeUHp99uQ3zb7XYOVjr3O9w/wacop-organisms-170619---Page-1

@flavour flavour self-assigned this Jul 6, 2017
@flavour
Copy link
Member Author

flavour commented Jul 6, 2017

@devinbalkind
I am working through this currently and have a question:
When the 'Draw a Map Area' button is pressed then we show the new panel (with instructions and buttons) and activate the draw control...OK so far, however currently the design shows the 'Draw a Map Area' button still visible so users might click on it again.
The simplest option for me is to simple disable the click handler on the button whilst the draw control is active, btu this still seems like poor UX which could be improved.
Options would be hiding the button or showing it as disabled:
https://uxplanet.org/button-ux-design-best-practices-types-and-states-647cf4ae0fc6#f57d

I guess the foundation "button disabled" class is what I should apply & then this style can be tweaked in CSS by Drew as-desired? (which could even meaning hide)
http://foundation.zurb.com/sites/docs/v/5.5.3/components/buttons.html#button-colors

@devinbalkind
Copy link
Member

Yes I think "button disabled" is good and we can turn the button gray to indicate it isn't clickable.

Pinging @dhornbein.

@dhornbein
Copy link

Has there been any markup added to the theme to display the polygon button in the filter? I'm not seeing anything to style.

@flavour
Copy link
Member Author

flavour commented Jul 14, 2017

This is still pending (stashed)

@flavour
Copy link
Member Author

flavour commented Jul 14, 2017

Basically there is a lot of Events need doing...this is way more than just style...and needs to also work with the current option

@devinbalkind
Copy link
Member

devinbalkind commented Jul 27, 2017

Hi. Fran, are you waiting on anything from us to move forward on this?

@flavour
Copy link
Member Author

flavour commented Aug 3, 2017

This has now been delivered to the Demo server & style can be tweaked if-necessary (I had a little camping holiday in Cornwall, hence the delay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants