Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formal Verification for Safe v1.5 Audit #901

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

derek-certora
Copy link
Contributor

This pull request corresponds to the formal verification aspect of the Safe v1.5 audit done by Certora.

Summary of Changes

Added

Configuration and Specification files corresponding to new rules:

  • execute.conf and Execute.spec
  • extensible.conf and Extensible.spec
  • fallback.conf and Fallback.spec
  • guards.conf and Guards.spec
  • hash.conf and Hash.spec
  • setup.conf and Setup.spec

Harness:

  • ExtensibleFallbackHandlerHarness.sol to reason about the fallback handler

Mocks:

  • DummyHandler.sol for reasoning about the fallback handler
  • TxnGuardMock.sol and TxnGuardMockDuplicate.sol for reasoning about the transaction guard
  • ModuleGuardMock.sol and ModuleGuardMockDuplicate.sol for reasoning about the module guard

Modified

  • applyHarness.patch - added some minor munging as explained in the audit report
  • run.conf - remove a deprecated configuration tag that was giving errors to the Prover
  • Safe.spec - moved a rule about guards to Guard.spec for logical continuity
  • SafeHarness.sol - added some view functionality to the Safe harness for some rules

certora audit for safe v1.5

---------

Co-authored-by: Derek Sorensen <[email protected]>
Copy link

github-actions bot commented Jan 15, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@derek-certora
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 15, 2025
@mmv08 mmv08 merged commit 8677f32 into safe-global:main Jan 16, 2025
9 of 17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants