Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly Request Required PR Permission for CLA Bot #692

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

nlordell
Copy link
Collaborator

@nlordell nlordell commented Oct 31, 2023

Change the CLA bot to explicitly request the required permissions. This is done in accordance to the CLA bot documentation:

# explicitly configure permissions, in case your GITHUB_TOKEN workflow permissions are set to read-only in repository settings
permissions:
  actions: write
  contents: write
  pull-requests: write
  statuses: write

@coveralls
Copy link

coveralls commented Oct 31, 2023

Pull Request Test Coverage Report for Build 6814151879

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.307%

Totals Coverage Status
Change from base Build 6720462527: 0.0%
Covered Lines: 400
Relevant Lines: 409

💛 - Coveralls

@nlordell nlordell requested review from a team, rmeissner, akshay-ap and mmv08 and removed request for a team October 31, 2023 12:37
@mmv08
Copy link
Member

mmv08 commented Oct 31, 2023

Does it work?

@nlordell
Copy link
Collaborator Author

nlordell commented Oct 31, 2023

It didn't work no, I kept the PR open as this adds the permissions that are recommended by the CLA bot documentation (see PR description), but maybe it's not needed after all.

Feel free to close if you don't think that it should be merged.

@nlordell nlordell force-pushed the change-cla-permissions branch from 6b0add3 to baf551f Compare November 9, 2023 15:48
@nlordell nlordell merged commit b71c65f into main Nov 13, 2023
17 of 18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
@nlordell nlordell deleted the change-cla-permissions branch April 16, 2024 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants