Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create native, ERC-20 and ERC-721 entities #2307

Open
iamacook opened this issue Jan 28, 2025 · 0 comments · May be fixed by #2309
Open

Create native, ERC-20 and ERC-721 entities #2307

iamacook opened this issue Jan 28, 2025 · 0 comments · May be fixed by #2309
Assignees
@iamacook
Labels
enhancement New feature or request

Comments

@iamacook
Copy link
Member

Description

We currently parse all token types the same. This results in a merged entity that doesn't follow standards, e.g. ERC-721 tokens should have 0 decimals, but are returned as null.

We should have explicit validation schemas and associated entities based on the token type. These should have the correct fallback values, should anything be returned as null, e.g. native token having 18 decimals, ERC-721 having 0 decimals, etc.

Requirements

  • TokenSchema should be split into three: NativeTokenSchema, Erc20TokenSchem, Erc721TokenSchema with correct fallback values.
  • Swagger-specific entities created for each of the above, tagged correctly.

Additional information
@iamacook iamacook added the enhancement New feature or request label Jan 28, 2025
@iamacook iamacook self-assigned this Jan 28, 2025
@github-project-automation github-project-automation bot moved this to New issues in Safe{Wallet} Jan 28, 2025
@iamacook iamacook linked a pull request Jan 28, 2025 that will close this issue
Draft
@iamacook iamacook moved this from New issues to In Progress in Safe{Wallet} Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamacook iamacook

Labels
enhancement New feature or request
Projects
Safe{Wallet}
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create token-specific entities safe-global/safe-client-gateway
1 participant
@iamacook