Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration upgrade from non L2 Safes to L2 Safes #285

Closed
moisses89 opened this issue Oct 30, 2023 · 3 comments · Fixed by #292
Closed

Add migration upgrade from non L2 Safes to L2 Safes #285

moisses89 opened this issue Oct 30, 2023 · 3 comments · Fixed by #292
Assignees
@Uxio0
Labels
enhancement New feature or request

Comments

@moisses89
Copy link
Member

What is needed?

Add command or include in upgrade command, support to migrate a non L2 Safe to L2 Safe

Related issues

safe-global/safe-transaction-service#1703
@moisses89 moisses89 added the enhancement New feature or request label Oct 30, 2023
@moisses89 moisses89 mentioned this issue Oct 30, 2023
Merged
@Uxio0 Uxio0 self-assigned this Oct 30, 2023
This was referenced Oct 31, 2023
Closed
Merged
@Uxio0
Copy link
Member

Uxio0 commented Nov 6, 2023

@JagoFigueroa we require QA on this 🙏🏻 . The way to test it would be to deploy a Safe v1.1.1 and v1.3.0 (not L2) on Polygon, use the command update_to_l2 0x1Ba30910CE8Eb45b276aa7c89C38FC52228B85CB (that's the address for the not official migration contract in Polygon deployed by me) and then use the Safe with our official UI and check transactions show as expected

@JagoFigueroa
Copy link

Hola team! Working nicely for me, I updated 2 safes on Polygon one from 1.1.1 and another from 1.3.0 and was able to transact with them without any issues once updated from the CLI. Also tried tx-service mode and was able to update on UI from the queue.

Cheers!

@Uxio0
Copy link
Member

Uxio0 commented Nov 7, 2023

Thank you very much, I understand this feature was not easy to test!

@Uxio0 Uxio0 closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Uxio0 Uxio0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add update_to_l2 command safe-global/safe-cli
3 participants
@Uxio0 @moisses89 @JagoFigueroa