Replies: 1 comment
-
Closing due to competing priorities. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Problem
Including the
ast
field (Abstract Syntax Tree) in the contract artifacts leads to large NPM package sizes, i.e., 4.7mB for@sablier/v2-core
. And it's also an issue of noise - the AST in theLockupDynamic
artifact makes up for ~21k lines from a total of 26k lines in the JSON.On the flip side, the AST may be useful for static analysis and developer tooling support (since tools could reconstruct the original code by walking up the AST).
No good solution comes to mind, so I suggest keeping
ast
as is for the time being. It's also the past of least resistance because we wouldn't have to modify theprepare-artifacts.sh
script. However, we can circle back on this topic if it turns out to be a problem for integrators (e.g. if the large number of lines in the JSON impairs the DX).External Conversations
Package Size Comparison
@sablier/v2-core
@uniswap/v3-core
@ethers
Beta Was this translation helpful? Give feedback.
All reactions