You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As pointed out by @andreivladbrg in #467 (comment), there is a name collision between the isCancelable getter and the isCancelable storage variable (a field in the LockupLinear.Stream and LockupDynamic.Stream struct).
The getter returns false when the stream is SETTLED
However, the storage variable is still true in the struct returned by the getStream getter when the stream is SETTLED
Thus, we should consider finding a new name for the isCancelable storage variable.
If we don't find a solution ourselves, we should ask our auditors for guidance.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As pointed out by @andreivladbrg in #467 (comment), there is a name collision between the
isCancelable
getter and theisCancelable
storage variable (a field in theLockupLinear.Stream
andLockupDynamic.Stream
struct).false
when the stream isSETTLED
true
in the struct returned by thegetStream
getter when the stream isSETTLED
Thus, we should consider finding a new name for the
isCancelable
storage variable.If we don't find a solution ourselves, we should ask our auditors for guidance.
Beta Was this translation helpful? Give feedback.
All reactions