Implement Sablier as a Rust feature

[PaulRBerg]

I just noticed that REVM is adding support for Optimism as a Rust feature:

#[cfg(feature = "optimism")]

e.g. in specification.rs:

https://github.com/bluealloy/revm/blob/af88ee9968167a6eb286fc9f7ac9b022c5a6e13c/crates/primitives/src/specification.rs#L43-L70

What if we did the same for Sablier? As I see it, the benefits would be:

• Better separation between vanilla EVM and SabVM features
• Easier auditing
• Allow us to run SabVM in "vanilla EVM" mode in case this is required for debugging

cc @sablier-labs/sabvm

[IaroslavMazur]

General reply

This is a curious idea, and is worth trying out - at least, to find out what a final implementation of SabVM would look like in this scenario. Then, it could be compared (more fairly) to the current one.

---

Better separation between vanilla EVM and SabVM features

Good point. This should make debugging easier / narrow it down to just the SabVM-related sections.

Easier auditing

In fact, it might make the auditing harder.

We don't just do some extra stuff on top of what EVM does, but, also, do many things differently, at a fundamental level. Because of this, implementing SabVM as a Rust feature would require jamming our implementation into the feature-activated sections - and placing them alongside/next to the existing EVM code sections. Hence, the auditors would oftentimes need to follow 2 "mental threads" of execution (EVM & SabVM), instead of just one.

Allow us to run SabVM in "vanilla EVM" mode in case this is required for debugging

We could always debug the "vanilla EVM" by debugging revm, though. No need to support the "full vanilla" mode in SabVM for this 🙂

[PaulRBerg]

OK sounds good in this case I will close this discussion. Thanks for your input.