Refactor withdraw and withdrawMax

[smol-ninja]

I would like suggest the following changes:

// Rename
function withdrawMax(uint256 streamId, address to) external;
// to
function withdraw(uint256 streamId, address to) external;

Rationale: >90% of users would just like to withdraw maximum amount

// Rename
function withdraw(uint256 streamId, address to, uint40 time) external;
// to
function withdrawAt(uint256 streamId, address to, uint40 time) external;

Rationale: This should be treated as a special function that withdraws at a time t.

[andreivladbrg]

Interesting proposal

90% of users would just like to withdraw maximum amount

I think this might be right but we need first to make a query on dune to be sure

I am not in favor of renaming withdrawMax to withdraw

But we could rename withdraw to withdrawAt.

So:

function withdrawMax(uint256 streamId, address to) external;
function withdrawAt(uint256 streamId, address to, uint40 time) external;

Does it work for you?

[smol-ninja]

withdrawAt or withdrawTo? (I am in favour of withdrawAt and not in withdrawTo)

Not having withdraw works.

Similarly, in #53, withdrawMaxMultiple and withdrawMultipleAt?

[andreivladbrg]

withdrawAt, edited now, sorry

[smol-ninja]

As per the discussion between me and @andreivladbrg, we have decided to rename withdraw to withdrawAt and keep withdrawMax unchanged.

• Rename withdraw to withdrawAt #72