Should there be an end date to open ended streams? #40
Replies: 7 comments 41 replies
-
Oh thank you Shub! Was just writing a discussion myself on this. Pasting here.
On the OP:
Yes, but we can rebrand or still keep open-ended as a core feature, while offering this end-date as an advanced setting. It provides flexibility.
I agree. But is that a bad thing?
Yup. Although having it inside the core means one less dependency and less coordination cost with an external tool (who pays for the gas, what happens if the tx is not included in a block etc.). |
Beta Was this translation helpful? Give feedback.
-
Peteris asked to have an end date: https://github.com/sablier-labs/v2-open-ended/discussions/67. This also brings another question: Should there be a start date to open-ended streams? |
Beta Was this translation helpful? Give feedback.
-
Should we implement the optional end date to open-ended-streams in the first release? We had Peteris asked about it specifically. |
Beta Was this translation helpful? Give feedback.
-
I've caught up on all messages in this thread. My thoughts: There seem to be two ideas floating around: (i) implementing an actual end time and (ii) adding an informational getter that predicts the Unix timestamp when the sender's balance will be depleted to zero. Regarding the 2nd idea, I think we all agree that the getter would be helpful. Naming-wise, I propose we go with Now, onto the 1st idea. I'm sympathetic to it, although I'm inclined to implement if off-contract via a Gelato integration. Two reasons:
However, for the sake of brainstorming, let's suppose we will proceed with implementing this idea. I do see the benefit of an easier and more tight-knit front-end implementation. What would the new name of the contract be? Here are some suggestions:
P.S. I am against a signature-based implementation (as suggested by @smol-ninja in the OP). It seems like the most complicated of the bunch: the complexity would increase both in the smart contracts and in the UI. |
Beta Was this translation helpful? Give feedback.
-
Have we all agreed to the following?
If not, could you please respond to my last comment? @sablier-labs/solidity @razgraf. |
Beta Was this translation helpful? Give feedback.
-
Arguments in favour of having an end date (for future release): UX difficulties with unwanted debt #197. |
Beta Was this translation helpful? Give feedback.
-
@razgraf shared the following idea in Slack:
Currently, this behaviour can be achieved by the following (cc @andreivladbrg):
cancel
after 1 month which setsrps
to zero. In case sender doesn't call thecancel
, the stream will continue to accumulate debt but recipient wouldn't be able to withdraw anything.However, @razgraf pointed out that this might be a visual/cognitive blocker for users.
I have two comments on this:
Other ideas to implement this feature:
cancel
function can be called anytime by the sender (cc @andreivladbrg)cancel
that means sender can submit a signed data through the UI which can be used to execute cancel on their behalf but only after a specified date.Beta Was this translation helpful? Give feedback.
All reactions