function strftime is deprecated (php 8.1)

[hannob]

With PHP 8.1 I'm getting these warnings in the log:

PHP Deprecated:  Function strftime() is deprecated in [path]/include/functions.inc.php on line 143

The use of the strftime function is discouraged and will likely be removed in future PHP versions:
https://www.php.net/strftime

[garvinhicking]

Sadly don't have much time these days, but I'd suggest to use a polyfill to make it work again. Adjusting to the immutalbe DateTime Interface for legacy application is a major pain.

Example for a polyfill: https://bestofphp.com/repo/alphp-strftime

That could be copy+pasted to serendipity_compat.inc.php or something like that, and be a drop-in replacement...? @onli

[onli]

Using the polyfill sounds like a good idea to me!

[surrim]

Sadly don't have much time these days, but I'd suggest to use a polyfill to make it work again. Adjusting to the immutalbe DateTime Interface for legacy application is a major pain.

It seems it's quite a lot of work. There is another format for the date() function, no way to reuse the format strings in all translations without a polyfill.

[surrim]

Example for a polyfill: https://bestofphp.com/repo/alphp-strftime

That could be copy+pasted to serendipity_compat.inc.php or something like that, and be a drop-in replacement...? @onli

Works fine! 💃‍
I implemented that here, but it's not ready for merging because of other bugs.

[onli]

I think we can almost close this.

The polyfill works and is merged. I tested it now under PHP 8.2, 8.1, 8.0 and 7.4 - seemed completely fine.

However, on my test server I ran into the issue that PHPs intl extension was not installed. The fix was:

apt install php-intl
service apache 2 restart

But we need to add this to the documentation, the installer, and should also mention it in the upgrade notice for the next version.