Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider API key saved in session files in the clear #96

Open
oatmealm opened this issue Apr 2, 2024 · 3 comments
Open

Provider API key saved in session files in the clear #96

oatmealm opened this issue Apr 2, 2024 · 3 comments
Labels

Comments

@oatmealm
Copy link

oatmealm commented Apr 2, 2024

I've noticed the session key is saved in the clear with the session data... might need to be taken care of? Not a priority as far as I'm concerned and these files are not supposed to be shared I guess... I also think I would make users aware of ellama-sessions-directory ... it's a wonderful feature and I changed it, so these records are in my org directory and are searchable...

@s-kostyaev
Copy link
Owner

s-kostyaev commented Apr 2, 2024

I should think about it.

Probable solution: add ability to save session files in separate directory (like autosave files).

Another probable solution: encrypt/decrypt keys during save/load. But it will make things complicated. Not sure if I want to do it.

@eras
Copy link

eras commented Apr 7, 2024

Emacs has builtin gpg-support. I wonder if it would "just work" if ellama supported saving with extension .gpg? I recall there was a gitlab package for Emacs that used that approach for storing credentials.

@oatmealm
Copy link
Author

oatmealm commented Apr 7, 2024

Emacs has builtin gpg-support. I wonder if it would "just work" if ellama supported saving with extension .gpg? I recall there was a gitlab package for Emacs that used that approach for storing credentials.

In interactive mode at least, simply opening a file with the extension .gpg seems to activate encryption/decryption (in Doom Emacs AFAIK).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants