Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the name of a measure in a success model throws an error on the success modeling service #22

Open
lakhoune opened this issue Sep 1, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@lakhoune
Copy link
Member

lakhoune commented Sep 1, 2021

Describe the bug
If you change the measure name of a measure in the success model and delete the old measure name from the model then the success modeling service will throw an error.

The reason is that when we change the measure name in the evaluation center, we first send a request to update the measure catalog, and only if that request is successful do we send a new request to save the model.

The problem is that at that time we send the first request, the success modeling service will check that all measures in the success model are present in the measure catalog. But because we deleted the old measure and have not sent a request for the updated model the service complains that the measure is missing.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the modeling page of the evaluation center
  2. Choose a group and a service
  3. Create a measure
  4. Save the measure.
  5. Save the model
  6. Change the name of the measure
  7. Save the model again

Expected behavior
The model and catalog both should be updated correctly

@lakhoune
Copy link
Member Author

lakhoune commented Sep 1, 2021

For now, I have pushed a hotfix where the old measure is not deleted.
There are two solutions to fix the current issue:

  1. save both model and catalog at the same time
  2. don't delete measures when changing the name of a measure

@lakhoune lakhoune added the bug Something isn't working label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant