X11: Use bottom-right corner of IME cursor area as caret position. #3966
Conversation
There was a problem hiding this comment.
This is generally not correct, though, since the intended way to do is to pass an area that shouldn't be obscured rather than offset. The concepts are different here, I'd say.
Probably something from XNPreeditArea is how it should work.
I generally won't block this patch, but it should be mentioned in the docs what it does and probably we should suggest to pass just a line generally for cursor to not hit bugs in various setups.
|
That's fair, I can add documentation changes to that effect, and a couple comments in the backend mentioning other possible ways to do preedit area reports (though I haven't found any IM servers implementing |
xorgy
force-pushed
the
fix-x11-ime-position
branch
from
5781d66
to
3e4deee
Compare
XIM servers currently do not support preedit area reporting from clients and there may be no standard way to report it. Fcitx and iBus both place the candidate window descending descending from the caret, with the reported X font; but since winit does not report a font, the height of the line is assumed 0, so when we report the top left corner of the cursor area they will tend to obscure it. Taking this into account, the best default option is to report the bottom right corner of the cursor area, because it will tend not to obscure the preedit area when using `Window::set_ime_cursor_area` in the way suggested by documentation.
xorgy
force-pushed
the
fix-x11-ime-position
branch
from
3e4deee
to
4c196d6
Compare
|
I've added more to the documentation about the behavior, and added comments for rationale. |
xorgy
changed the title
XIM servers currently do not support preedit area reporting from
clients and there may be no standard way to report it.
Fcitx and iBus both place the candidate window descending descending
from the caret, with the reported X font; but since winit does not
report a font, the height of the line is assumed 0, so when we report
the top left corner of the cursor area they will tend to obscure it.
Taking this into account, the best default option is to report the
bottom right corner of the cursor area, because it will tend not to
obscure the preedit area when using
Window::set_ime_cursor_areainthe way suggested by documentation.
Fixes #3965