-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameActivity signatures changed #150
Comments
Somehow it works now, on multiple android devices (still winit 0.29.10); |
The issue occurs when you update the android dependencies in app/build.gradle (as provided by agdk apps in rust-android-examples repository) to a more recent version. The android-activity code (signatures) have to be changed at some point to support new/fixed functionality from these linked java classes as support for the older version wanes. |
i found this, androidx.games:games-activity package version in gradle must match version in android-activity/game-activity-csrc/game-activity/GameActivity.h #define GAMEACTIVITY_MAJOR_VERSION 2 |
If I update everything to the latest versions in agdk-winit-wgpu, fix the compiler errors and run it on Android 13, I get:
build.gradle:
app/build.gradle:
Cargo.toml:
So the last parameter of initializeNativeCode is a byte[] now, instead of android.content.res.Configuration.
I tried with various combinations of versions, but it looks like the GameActivity method signatures have changed (g_methods) and need to be updated at some point in order to keep up, possibly other changes as well. I'm just opening a case for it.
The example works with winit 0.28 and wgpu 0.18 (after fixing some compiler errors) so that can be used for now.
The text was updated successfully, but these errors were encountered: