-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal implimentation of prefetch #414
Comments
|
I'll take a look while I'm doing the |
There is nothing for instructions. Does it make sense to use a data prefetch call in place of an instruction prefetch? |
I'm not sure. It could be interesting to try and see if the resulting assembly is affected. |
The assembly will be different on many platforms, but maybe a data prefetch will still benefit instruction load time if it brings it from main memory to intermediate cache. While experimenting does sound interesting, I think we will get better results by asking an expert in computer architecture. I'm assuming we can use conditional compilation and only use it on targets that would benefit. In the mean time, I lean towards being conservative and making instruction prefetch a noop. |
That's OK for me. |
rustc_codegen_gcc/src/intrinsic/mod.rs
Lines 170 to 175 in 1a8e0c3
Currently, all the prefetch operations lead to
unimplemented!()
macro. However, prefetches are just a suggestion and can be interpreted as a noop, like assume is.The text was updated successfully, but these errors were encountered: