From f2e19d05935e706547c78c0de04827e69f5fdaa2 Mon Sep 17 00:00:00 2001
From: Sarthak Singh <sarthak.singh99@gmail.com>
Date: Mon, 22 Jul 2024 14:30:19 +0530
Subject: [PATCH 1/4] Continue inside a labeled block now lowers to a error
 when to lowering the ast

---
 compiler/rustc_ast_lowering/messages.ftl      |  5 +++
 compiler/rustc_ast_lowering/src/errors.rs     | 10 +++++
 compiler/rustc_ast_lowering/src/expr.rs       | 20 ++++++---
 compiler/rustc_ast_lowering/src/lib.rs        |  2 +-
 compiler/rustc_middle/src/ty/mod.rs           |  3 +-
 compiler/rustc_resolve/src/late.rs            | 44 +++++++++++++------
 .../rustc_resolve/src/late/diagnostics.rs     |  2 +-
 compiler/rustc_resolve/src/lib.rs             |  3 +-
 tests/crashes/113379.rs                       |  7 ---
 .../label/label_break_value_continue.stderr   | 12 ++---
 .../cont-in-block/cont-in-fn-issue-113379.rs  | 31 +++++++++++++
 .../cont-in-fn-issue-113379.stderr            | 33 ++++++++++++++
 .../cont-in-match-arm-issue-121623.rs}        |  4 +-
 .../cont-in-match-arm-issue-121623.stderr     | 14 ++++++
 14 files changed, 153 insertions(+), 37 deletions(-)
 delete mode 100644 tests/crashes/113379.rs
 create mode 100644 tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs
 create mode 100644 tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
 rename tests/{crashes/121623.rs => ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.rs} (64%)
 create mode 100644 tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.stderr

diff --git a/compiler/rustc_ast_lowering/messages.ftl b/compiler/rustc_ast_lowering/messages.ftl
index 9ed93d481e773..566915b85dfb4 100644
--- a/compiler/rustc_ast_lowering/messages.ftl
+++ b/compiler/rustc_ast_lowering/messages.ftl
@@ -54,6 +54,11 @@ ast_lowering_clobber_abi_not_supported =
 
 ast_lowering_closure_cannot_be_static = closures cannot be static
 
+ast_lowering_continue_labeled_block =
+    `continue` pointing to a labeled block
+    .label = labeled blocks cannot be `continue`'d
+    .block_label = labeled block the `continue` points to
+
 ast_lowering_coroutine_too_many_parameters =
     too many parameters for a coroutine (expected 0 or 1 parameters)
 
diff --git a/compiler/rustc_ast_lowering/src/errors.rs b/compiler/rustc_ast_lowering/src/errors.rs
index 7a6c9d8d0d375..ea1139e972cb6 100644
--- a/compiler/rustc_ast_lowering/src/errors.rs
+++ b/compiler/rustc_ast_lowering/src/errors.rs
@@ -451,3 +451,13 @@ pub(crate) struct YieldInClosure {
     #[suggestion(code = "#[coroutine] ", applicability = "maybe-incorrect", style = "verbose")]
     pub suggestion: Option<Span>,
 }
+
+#[derive(Diagnostic)]
+#[diag(ast_lowering_continue_labeled_block, code = E0696)]
+pub struct ContinueLabeledBlock {
+    #[primary_span]
+    #[label]
+    pub span: Span,
+    #[label(ast_lowering_block_label)]
+    pub block_span: Span,
+}
diff --git a/compiler/rustc_ast_lowering/src/expr.rs b/compiler/rustc_ast_lowering/src/expr.rs
index 124fe6bd380d2..57107bbc49333 100644
--- a/compiler/rustc_ast_lowering/src/expr.rs
+++ b/compiler/rustc_ast_lowering/src/expr.rs
@@ -15,14 +15,13 @@ use thin_vec::{thin_vec, ThinVec};
 
 use super::errors::{
     AsyncCoroutinesNotSupported, AwaitOnlyInAsyncFnAndBlocks, BaseExpressionDoubleDot,
-    ClosureCannotBeStatic, CoroutineTooManyParameters,
+    ClosureCannotBeStatic, ContinueLabeledBlock, CoroutineTooManyParameters,
     FunctionalRecordUpdateDestructuringAssignment, InclusiveRangeWithNoEnd, MatchArmWithNoBody,
-    NeverPatternWithBody, NeverPatternWithGuard, UnderscoreExprLhsAssign,
+    NeverPatternWithBody, NeverPatternWithGuard, UnderscoreExprLhsAssign, YieldInClosure,
 };
 use super::{
     ImplTraitContext, LoweringContext, ParamMode, ParenthesizedGenericArgs, ResolverAstLoweringExt,
 };
-use crate::errors::YieldInClosure;
 use crate::{FnDeclKind, ImplTraitPosition};
 
 impl<'hir> LoweringContext<'_, 'hir> {
@@ -291,7 +290,16 @@ impl<'hir> LoweringContext<'_, 'hir> {
                     hir::ExprKind::Break(self.lower_jump_destination(e.id, *opt_label), opt_expr)
                 }
                 ExprKind::Continue(opt_label) => {
-                    hir::ExprKind::Continue(self.lower_jump_destination(e.id, *opt_label))
+                    if opt_label.is_some()
+                        && let Some((_, is_loop, block_span)) = self.resolver.get_label_res(e.id)
+                        && !is_loop
+                    {
+                        hir::ExprKind::Err(
+                            self.dcx().emit_err(ContinueLabeledBlock { span: e.span, block_span }),
+                        )
+                    } else {
+                        hir::ExprKind::Continue(self.lower_jump_destination(e.id, *opt_label))
+                    }
                 }
                 ExprKind::Ret(e) => {
                     let e = e.as_ref().map(|x| self.lower_expr(x));
@@ -1470,8 +1478,8 @@ impl<'hir> LoweringContext<'_, 'hir> {
     fn lower_loop_destination(&mut self, destination: Option<(NodeId, Label)>) -> hir::Destination {
         let target_id = match destination {
             Some((id, _)) => {
-                if let Some(loop_id) = self.resolver.get_label_res(id) {
-                    Ok(self.lower_node_id(loop_id))
+                if let Some((id, _is_loop, _)) = self.resolver.get_label_res(id) {
+                    Ok(self.lower_node_id(id))
                 } else {
                     Err(hir::LoopIdError::UnresolvedLabel)
                 }
diff --git a/compiler/rustc_ast_lowering/src/lib.rs b/compiler/rustc_ast_lowering/src/lib.rs
index 224787c335beb..e04b8af135842 100644
--- a/compiler/rustc_ast_lowering/src/lib.rs
+++ b/compiler/rustc_ast_lowering/src/lib.rs
@@ -252,7 +252,7 @@ impl ResolverAstLowering {
     }
 
     /// Obtains resolution for a label with the given `NodeId`.
-    fn get_label_res(&self, id: NodeId) -> Option<NodeId> {
+    fn get_label_res(&self, id: NodeId) -> Option<(NodeId, bool, Span)> {
         self.label_res_map.get(&id).copied()
     }
 
diff --git a/compiler/rustc_middle/src/ty/mod.rs b/compiler/rustc_middle/src/ty/mod.rs
index 9736428e6f7c7..98aabc7b8072a 100644
--- a/compiler/rustc_middle/src/ty/mod.rs
+++ b/compiler/rustc_middle/src/ty/mod.rs
@@ -203,7 +203,8 @@ pub struct ResolverAstLowering {
     /// Resolutions for import nodes, which have multiple resolutions in different namespaces.
     pub import_res_map: NodeMap<hir::def::PerNS<Option<Res<ast::NodeId>>>>,
     /// Resolutions for labels (node IDs of their corresponding blocks or loops).
-    pub label_res_map: NodeMap<ast::NodeId>,
+    /// The boolean stores if the node is loop. The span is the span of the node.
+    pub label_res_map: NodeMap<(ast::NodeId, bool, Span)>,
     /// Resolutions for lifetimes.
     pub lifetimes_res_map: NodeMap<LifetimeRes>,
     /// Lifetime parameters that lowering will have to introduce.
diff --git a/compiler/rustc_resolve/src/late.rs b/compiler/rustc_resolve/src/late.rs
index 7e5fd82b80cee..777ae128b79ef 100644
--- a/compiler/rustc_resolve/src/late.rs
+++ b/compiler/rustc_resolve/src/late.rs
@@ -672,7 +672,7 @@ struct LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
     last_block_rib: Option<Rib<'a>>,
 
     /// The current set of local scopes, for labels.
-    label_ribs: Vec<Rib<'a, NodeId>>,
+    label_ribs: Vec<Rib<'a, (NodeId, bool, Span)>>,
 
     /// The current set of local scopes for lifetimes.
     lifetime_ribs: Vec<LifetimeRib>,
@@ -2316,7 +2316,10 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
 
     /// Searches the current set of local scopes for labels. Returns the `NodeId` of the resolved
     /// label and reports an error if the label is not found or is unreachable.
-    fn resolve_label(&mut self, mut label: Ident) -> Result<(NodeId, Span), ResolutionError<'a>> {
+    fn resolve_label(
+        &mut self,
+        mut label: Ident,
+    ) -> Result<((NodeId, bool, Span), Span), ResolutionError<'a>> {
         let mut suggestion = None;
 
         for i in (0..self.label_ribs.len()).rev() {
@@ -4333,7 +4336,14 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
         Ok(Some(result))
     }
 
-    fn with_resolved_label(&mut self, label: Option<Label>, id: NodeId, f: impl FnOnce(&mut Self)) {
+    fn with_resolved_label(
+        &mut self,
+        label: Option<Label>,
+        id: NodeId,
+        is_loop: bool,
+        span: Span,
+        f: impl FnOnce(&mut Self),
+    ) {
         if let Some(label) = label {
             if label.ident.as_str().as_bytes()[1] != b'_' {
                 self.diag_metadata.unused_labels.insert(id, label.ident.span);
@@ -4345,7 +4355,7 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
 
             self.with_label_rib(RibKind::Normal, |this| {
                 let ident = label.ident.normalize_to_macro_rules();
-                this.label_ribs.last_mut().unwrap().bindings.insert(ident, id);
+                this.label_ribs.last_mut().unwrap().bindings.insert(ident, (id, is_loop, span));
                 f(this);
             });
         } else {
@@ -4353,8 +4363,14 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
         }
     }
 
-    fn resolve_labeled_block(&mut self, label: Option<Label>, id: NodeId, block: &'ast Block) {
-        self.with_resolved_label(label, id, |this| this.visit_block(block));
+    fn resolve_labeled_block(
+        &mut self,
+        label: Option<Label>,
+        id: NodeId,
+        block: &'ast Block,
+        is_loop: bool,
+    ) {
+        self.with_resolved_label(label, id, is_loop, block.span, |this| this.visit_block(block));
     }
 
     fn resolve_block(&mut self, block: &'ast Block) {
@@ -4497,10 +4513,10 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
 
             ExprKind::Break(Some(label), _) | ExprKind::Continue(Some(label)) => {
                 match self.resolve_label(label.ident) {
-                    Ok((node_id, _)) => {
+                    Ok((node, _)) => {
                         // Since this res is a label, it is never read.
-                        self.r.label_res_map.insert(expr.id, node_id);
-                        self.diag_metadata.unused_labels.remove(&node_id);
+                        self.r.label_res_map.insert(expr.id, node);
+                        self.diag_metadata.unused_labels.remove(&node.0);
                     }
                     Err(error) => {
                         self.report_error(label.ident.span, error);
@@ -4535,11 +4551,11 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
             }
 
             ExprKind::Loop(ref block, label, _) => {
-                self.resolve_labeled_block(label, expr.id, block)
+                self.resolve_labeled_block(label, expr.id, block, true)
             }
 
             ExprKind::While(ref cond, ref block, label) => {
-                self.with_resolved_label(label, expr.id, |this| {
+                self.with_resolved_label(label, expr.id, true, block.span, |this| {
                     this.with_rib(ValueNS, RibKind::Normal, |this| {
                         let old = this.diag_metadata.in_if_condition.replace(cond);
                         this.visit_expr(cond);
@@ -4553,11 +4569,13 @@ impl<'a: 'ast, 'b, 'ast, 'tcx> LateResolutionVisitor<'a, 'b, 'ast, 'tcx> {
                 self.visit_expr(iter);
                 self.with_rib(ValueNS, RibKind::Normal, |this| {
                     this.resolve_pattern_top(pat, PatternSource::For);
-                    this.resolve_labeled_block(label, expr.id, body);
+                    this.resolve_labeled_block(label, expr.id, body, true);
                 });
             }
 
-            ExprKind::Block(ref block, label) => self.resolve_labeled_block(label, block.id, block),
+            ExprKind::Block(ref block, label) => {
+                self.resolve_labeled_block(label, block.id, block, false)
+            }
 
             // Equivalent to `visit::walk_expr` + passing some context to children.
             ExprKind::Field(ref subexpression, _) => {
diff --git a/compiler/rustc_resolve/src/late/diagnostics.rs b/compiler/rustc_resolve/src/late/diagnostics.rs
index f126563fe58f0..0ffaba59d83b8 100644
--- a/compiler/rustc_resolve/src/late/diagnostics.rs
+++ b/compiler/rustc_resolve/src/late/diagnostics.rs
@@ -935,7 +935,7 @@ impl<'a: 'ast, 'ast, 'tcx> LateResolutionVisitor<'a, '_, 'ast, 'tcx> {
         if let Some(err_code) = err.code {
             if err_code == E0425 {
                 for label_rib in &self.label_ribs {
-                    for (label_ident, node_id) in &label_rib.bindings {
+                    for (label_ident, (node_id, _, _)) in &label_rib.bindings {
                         let ident = path.last().unwrap().ident;
                         if format!("'{ident}") == label_ident.to_string() {
                             err.span_label(label_ident.span, "a label with a similar name exists");
diff --git a/compiler/rustc_resolve/src/lib.rs b/compiler/rustc_resolve/src/lib.rs
index 6aca0545e64de..6f0c859ddc240 100644
--- a/compiler/rustc_resolve/src/lib.rs
+++ b/compiler/rustc_resolve/src/lib.rs
@@ -1017,7 +1017,8 @@ pub struct Resolver<'a, 'tcx> {
     /// Resolutions for import nodes, which have multiple resolutions in different namespaces.
     import_res_map: NodeMap<PerNS<Option<Res>>>,
     /// Resolutions for labels (node IDs of their corresponding blocks or loops).
-    label_res_map: NodeMap<NodeId>,
+    /// The boolean stores if the node is loop. The span is the span of the node.
+    label_res_map: NodeMap<(NodeId, bool, Span)>,
     /// Resolutions for lifetimes.
     lifetimes_res_map: NodeMap<LifetimeRes>,
     /// Lifetime parameters that lowering will have to introduce.
diff --git a/tests/crashes/113379.rs b/tests/crashes/113379.rs
deleted file mode 100644
index 7163cbc39342d..0000000000000
--- a/tests/crashes/113379.rs
+++ /dev/null
@@ -1,7 +0,0 @@
-//@ known-bug: #113379
-
-async fn f999() -> Vec<usize> {
-    'b: {
-        continue 'b;
-    }
-}
diff --git a/tests/ui/label/label_break_value_continue.stderr b/tests/ui/label/label_break_value_continue.stderr
index 284d213d65eaa..792ba4c0b25c6 100644
--- a/tests/ui/label/label_break_value_continue.stderr
+++ b/tests/ui/label/label_break_value_continue.stderr
@@ -1,9 +1,3 @@
-error[E0695]: unlabeled `continue` inside of a labeled block
-  --> $DIR/label_break_value_continue.rs:6:9
-   |
-LL |         continue;
-   |         ^^^^^^^^ `continue` statements that would diverge to or through a labeled block need to bear a label
-
 error[E0696]: `continue` pointing to a labeled block
   --> $DIR/label_break_value_continue.rs:13:9
    |
@@ -13,6 +7,12 @@ LL | |         continue 'b;
 LL | |     }
    | |_____- labeled block the `continue` points to
 
+error[E0695]: unlabeled `continue` inside of a labeled block
+  --> $DIR/label_break_value_continue.rs:6:9
+   |
+LL |         continue;
+   |         ^^^^^^^^ `continue` statements that would diverge to or through a labeled block need to bear a label
+
 error[E0695]: unlabeled `continue` inside of a labeled block
   --> $DIR/label_break_value_continue.rs:21:13
    |
diff --git a/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs
new file mode 100644
index 0000000000000..d7d7199740677
--- /dev/null
+++ b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs
@@ -0,0 +1,31 @@
+// Fixes: #113379
+
+#![allow(incomplete_features)]
+#![feature(adt_const_params)]
+
+trait Trait<const S: usize> {}
+
+struct Bug<T>
+where
+    T: Trait<
+        {
+            'b: {
+                //~^ ERROR [E0308]
+                continue 'b; //~ ERROR [E0696]
+            }
+        },
+    >,
+{
+    t: T,
+}
+
+fn f() -> impl Sized {
+    'b: {
+        continue 'b;
+        //~^ ERROR [E0696]
+    }
+}
+
+fn main() {
+    f();
+}
diff --git a/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
new file mode 100644
index 0000000000000..bb89d7d0cb951
--- /dev/null
+++ b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
@@ -0,0 +1,33 @@
+error[E0696]: `continue` pointing to a labeled block
+  --> $DIR/cont-in-fn-issue-113379.rs:12:17
+   |
+LL | /             'b: {
+LL | |
+LL | |                 continue 'b;
+   | |                 ^^^^^^^^^^^ labeled blocks cannot be `continue`'d
+LL | |             }
+   | |_____________- labeled block the `continue` points to
+
+error[E0696]: `continue` pointing to a labeled block
+  --> $DIR/cont-in-fn-issue-113379.rs:22:9
+   |
+LL | /     'b: {
+LL | |         continue 'b;
+   | |         ^^^^^^^^^^^ labeled blocks cannot be `continue`'d
+LL | |
+LL | |     }
+   | |_____- labeled block the `continue` points to
+
+error[E0308]: mismatched types
+  --> $DIR/cont-in-fn-issue-113379.rs:10:13
+   |
+LL | /             'b: {
+LL | |
+LL | |                 continue 'b;
+LL | |             }
+   | |_____________^ expected `usize`, found `()`
+
+error: aborting due to 3 previous errors
+
+Some errors have detailed explanations: E0308, E0696.
+For more information about an error, try `rustc --explain E0308`.
diff --git a/tests/crashes/121623.rs b/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.rs
similarity index 64%
rename from tests/crashes/121623.rs
rename to tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.rs
index 3c01a7f452ca7..610ff05a3b120 100644
--- a/tests/crashes/121623.rs
+++ b/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.rs
@@ -1,8 +1,10 @@
-//@ known-bug: #121623
+// Fixes: #121623
+
 fn main() {
     match () {
         _ => 'b: {
             continue 'b;
+            //~^ ERROR [E0696]
         }
     }
 }
diff --git a/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.stderr b/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.stderr
new file mode 100644
index 0000000000000..ffe7331031d7a
--- /dev/null
+++ b/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.stderr
@@ -0,0 +1,14 @@
+error[E0696]: `continue` pointing to a labeled block
+  --> $DIR/cont-in-match-arm-issue-121623.rs:4:13
+   |
+LL |           _ => 'b: {
+   |  ______________-
+LL | |             continue 'b;
+   | |             ^^^^^^^^^^^ labeled blocks cannot be `continue`'d
+LL | |
+LL | |         }
+   | |_________- labeled block the `continue` points to
+
+error: aborting due to 1 previous error
+
+For more information about this error, try `rustc --explain E0696`.

From 06f33dc2ca4d15f5a765333209d4e217423b6d0b Mon Sep 17 00:00:00 2001
From: Sarthak Singh <sarthak.singh99@gmail.com>
Date: Mon, 22 Jul 2024 22:39:06 +0530
Subject: [PATCH 2/4] Removed redundant check for label being block for
 continue

---
 compiler/rustc_passes/messages.ftl  |  5 -----
 compiler/rustc_passes/src/errors.rs | 10 ----------
 compiler/rustc_passes/src/loops.rs  | 14 +++++---------
 3 files changed, 5 insertions(+), 24 deletions(-)

diff --git a/compiler/rustc_passes/messages.ftl b/compiler/rustc_passes/messages.ftl
index bfe0d54e64521..a8c3a97e7679d 100644
--- a/compiler/rustc_passes/messages.ftl
+++ b/compiler/rustc_passes/messages.ftl
@@ -95,11 +95,6 @@ passes_collapse_debuginfo =
 passes_confusables = attribute should be applied to an inherent method
     .label = not an inherent method
 
-passes_continue_labeled_block =
-    `continue` pointing to a labeled block
-    .label = labeled blocks cannot be `continue`'d
-    .block_label = labeled block the `continue` points to
-
 passes_coverage_not_fn_or_closure =
     attribute should be applied to a function definition or closure
     .label = not a function or closure
diff --git a/compiler/rustc_passes/src/errors.rs b/compiler/rustc_passes/src/errors.rs
index ff85be109d460..6d20198682164 100644
--- a/compiler/rustc_passes/src/errors.rs
+++ b/compiler/rustc_passes/src/errors.rs
@@ -1044,16 +1044,6 @@ impl<'a, G: EmissionGuarantee> Diagnostic<'_, G> for BreakNonLoop<'a> {
     }
 }
 
-#[derive(Diagnostic)]
-#[diag(passes_continue_labeled_block, code = E0696)]
-pub struct ContinueLabeledBlock {
-    #[primary_span]
-    #[label]
-    pub span: Span,
-    #[label(passes_block_label)]
-    pub block_span: Span,
-}
-
 #[derive(Diagnostic)]
 #[diag(passes_break_inside_closure, code = E0267)]
 pub struct BreakInsideClosure<'a> {
diff --git a/compiler/rustc_passes/src/loops.rs b/compiler/rustc_passes/src/loops.rs
index 25115c5cafd89..8311ca39c2dd3 100644
--- a/compiler/rustc_passes/src/loops.rs
+++ b/compiler/rustc_passes/src/loops.rs
@@ -15,8 +15,8 @@ use rustc_span::{BytePos, Span};
 use Context::*;
 
 use crate::errors::{
-    BreakInsideClosure, BreakInsideCoroutine, BreakNonLoop, ContinueLabeledBlock, OutsideLoop,
-    OutsideLoopSuggestion, UnlabeledCfInWhileCondition, UnlabeledInLabeledBlock,
+    BreakInsideClosure, BreakInsideCoroutine, BreakNonLoop, OutsideLoop, OutsideLoopSuggestion,
+    UnlabeledCfInWhileCondition, UnlabeledInLabeledBlock,
 };
 
 #[derive(Clone, Copy, Debug, PartialEq)]
@@ -266,13 +266,9 @@ impl<'a, 'hir> Visitor<'hir> for CheckLoopVisitor<'a, 'hir> {
                 self.require_label_in_labeled_block(e.span, &destination, "continue");
 
                 match destination.target_id {
-                    Ok(loop_id) => {
-                        if let Node::Block(block) = self.tcx.hir_node(loop_id) {
-                            self.sess.dcx().emit_err(ContinueLabeledBlock {
-                                span: e.span,
-                                block_span: block.span,
-                            });
-                        }
+                    Ok(_loop_id) => {
+                        // We have already insured that the loop exists while lowering the ast.
+                        // See `compiler/rustc_ast_lowering/src/expr.rs::LoweringContext::lower_expr_mut`
                     }
                     Err(hir::LoopIdError::UnlabeledCfInWhileCondition) => {
                         self.sess.dcx().emit_err(UnlabeledCfInWhileCondition {

From d5b4bb13a7172d1d7d9b3f3e82e045c8361a6742 Mon Sep 17 00:00:00 2001
From: Sarthak Singh <sarthak.singh99@gmail.com>
Date: Tue, 23 Jul 2024 12:22:26 +0530
Subject: [PATCH 3/4] Updated stderr outputs

---
 .../lowering/cont-in-block/cont-in-fn-issue-113379.stderr   | 6 +++---
 .../cont-in-block/cont-in-match-arm-issue-121623.stderr     | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
index bb89d7d0cb951..59e987d20deb6 100644
--- a/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
+++ b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
@@ -1,5 +1,5 @@
 error[E0696]: `continue` pointing to a labeled block
-  --> $DIR/cont-in-fn-issue-113379.rs:12:17
+  --> $DIR/cont-in-fn-issue-113379.rs:14:17
    |
 LL | /             'b: {
 LL | |
@@ -9,7 +9,7 @@ LL | |             }
    | |_____________- labeled block the `continue` points to
 
 error[E0696]: `continue` pointing to a labeled block
-  --> $DIR/cont-in-fn-issue-113379.rs:22:9
+  --> $DIR/cont-in-fn-issue-113379.rs:24:9
    |
 LL | /     'b: {
 LL | |         continue 'b;
@@ -19,7 +19,7 @@ LL | |     }
    | |_____- labeled block the `continue` points to
 
 error[E0308]: mismatched types
-  --> $DIR/cont-in-fn-issue-113379.rs:10:13
+  --> $DIR/cont-in-fn-issue-113379.rs:12:13
    |
 LL | /             'b: {
 LL | |
diff --git a/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.stderr b/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.stderr
index ffe7331031d7a..b642110023c1d 100644
--- a/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.stderr
+++ b/tests/ui/lowering/cont-in-block/cont-in-match-arm-issue-121623.stderr
@@ -1,5 +1,5 @@
 error[E0696]: `continue` pointing to a labeled block
-  --> $DIR/cont-in-match-arm-issue-121623.rs:4:13
+  --> $DIR/cont-in-match-arm-issue-121623.rs:6:13
    |
 LL |           _ => 'b: {
    |  ______________-

From f490a0e10ef1d5f96521437982ce18b511ca6676 Mon Sep 17 00:00:00 2001
From: Sarthak Singh <sarthak.singh99@gmail.com>
Date: Tue, 23 Jul 2024 12:27:54 +0530
Subject: [PATCH 4/4] Removed unused feature from test

---
 tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs  | 3 ---
 .../lowering/cont-in-block/cont-in-fn-issue-113379.stderr   | 6 +++---
 2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs
index d7d7199740677..34962f55c5fe1 100644
--- a/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs
+++ b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.rs
@@ -1,8 +1,5 @@
 // Fixes: #113379
 
-#![allow(incomplete_features)]
-#![feature(adt_const_params)]
-
 trait Trait<const S: usize> {}
 
 struct Bug<T>
diff --git a/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
index 59e987d20deb6..121ab748fbc97 100644
--- a/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
+++ b/tests/ui/lowering/cont-in-block/cont-in-fn-issue-113379.stderr
@@ -1,5 +1,5 @@
 error[E0696]: `continue` pointing to a labeled block
-  --> $DIR/cont-in-fn-issue-113379.rs:14:17
+  --> $DIR/cont-in-fn-issue-113379.rs:11:17
    |
 LL | /             'b: {
 LL | |
@@ -9,7 +9,7 @@ LL | |             }
    | |_____________- labeled block the `continue` points to
 
 error[E0696]: `continue` pointing to a labeled block
-  --> $DIR/cont-in-fn-issue-113379.rs:24:9
+  --> $DIR/cont-in-fn-issue-113379.rs:21:9
    |
 LL | /     'b: {
 LL | |         continue 'b;
@@ -19,7 +19,7 @@ LL | |     }
    | |_____- labeled block the `continue` points to
 
 error[E0308]: mismatched types
-  --> $DIR/cont-in-fn-issue-113379.rs:12:13
+  --> $DIR/cont-in-fn-issue-113379.rs:9:13
    |
 LL | /             'b: {
 LL | |