Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #129897: deprecate -Csoft-float because it is unsound (and not fixable) #130968

Closed
3 tasks
rustbot opened this issue Sep 28, 2024 · 5 comments
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2024

This issue tracks the release notes text for #129897.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Compiler
- [Deprecate unsound `-Csoft-float` flag](https://github.com/rust-lang/rust/pull/129897)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

cc @RalfJung, @Urgau -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2024
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 28, 2024
@fmease fmease removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 28, 2024
@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2024

Given that this is such a niche flag, I am not sure this needs a dedicated section in the release notes.

@Urgau
Copy link
Member

Urgau commented Nov 2, 2024

What do you mean by dedicated section? It's currently going to be a one liner in the "Compiler" section with the rest of the compiler stuff.

@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2024

Yes. But these tracking issues are also about deciding whether we need a dedicated release note sections that appears in the blog post.

@Urgau
Copy link
Member

Urgau commented Nov 2, 2024

Sure, but since you deleted the section related to the blog post you already made the decision sometime ago (hence my confusion).

(Which I agree btw, this change is way too minor to be blog post worthy)

@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2024

I felt it'd be good to be explicit rather than implicit, is all. :)

@cuviper cuviper closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants