Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help hover / completions no longer "sees through" smart pointer types implementing Deref (like Arc) #19065

Closed
DavisVaughan opened this issue Jan 28, 2025 · 2 comments
Labels
C-bug Category: bug

Comments

@DavisVaughan
Copy link
Contributor

rust-analyzer version: 0.4.2283-standalone (a995319 2025-01-27)

rustc version: rustc 1.83.0 (90b35a623 2024-11-26)

editor or extension: VSCode

If you have a snippet of code like this

pub fn start(runtime: Arc<tokio::runtime::Runtime>) {
    runtime.block_on(async {})
}

then in the release version of RA if you hover over block_on() then you'll get a help popup, and if you type runtime. you'll get completions for Runtime. Neither of these are working in the current pre-release.

Here is a video showing the issue (slightly too big to upload straight to github, sorry):
https://vimeo.com/manage/videos/1051266094

@DavisVaughan DavisVaughan added the C-bug Category: bug label Jan 28, 2025
@DavisVaughan
Copy link
Contributor Author

DavisVaughan commented Jan 28, 2025

I think this may be a duplicate of #19040, they mention they can't get underlying target completions when the type is a MutexGuard, and I've also seen an issue with that as well (that also used to work in the release version)

@ShoyuVanilla
Copy link
Member

I think that this is #19059, which has been fixed in our newest release(2025-01-28) via #19061. Sorry for the inconveniences.

@Veykril Veykril closed this as completed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

3 participants