Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused birth field in MasterAccount structure #10

Open
dr-orlovsky opened this issue Jan 4, 2020 · 1 comment
Open

Unused birth field in MasterAccount structure #10

dr-orlovsky opened this issue Jan 4, 2020 · 1 comment

Comments

@dr-orlovsky
Copy link

The birth field in defined in https://github.com/rust-bitcoin/rust-wallet/blob/master/src/account.rs#L66 presumably stores the timestamp of the master key creation, however it is nowhere used outside of the MasterAccount and there is nothing in Bitcoin specs that defines it's usage. Should it be removed?

@notmandatory
Copy link

@dr-orlovsky I agree birth isn't needed in the MasterAccount structure.

I checked in the defiads project wallet.rs file and found the MasterAccount.birth field is used in a function. But that function is only used once to initialize the defiads main.rs defiands.cfg file. It would be an easy refactor to call now() directly when creating defiads.cfg to keep track of the wallet's birthday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants