Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use std's siphash to produce secret key fingerprints #725

Closed
Kixunil opened this issue Aug 24, 2024 · 0 comments · Fixed by #726
Closed

Don't use std's siphash to produce secret key fingerprints #725

Kixunil opened this issue Aug 24, 2024 · 0 comments · Fixed by #726

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Aug 24, 2024

TL;DR: printing siphash of private keys is questionable cryptographically at best and people might accidentally rely on it despite it being unstable. Just replace it with a message saying to turn on hashes in secp256k1 if they want to see a fingerprint.

Originally posted by @apoelstra in #722 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

key: don't use Hasher to generate fingerprints; just use hashes crate apoelstra/rust-secp256k1
1 participant
@Kixunil