Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless/broken reexport of hashes #723

Open
Kixunil opened this issue Aug 23, 2024 · 2 comments
Open

Remove useless/broken reexport of hashes #723

Kixunil opened this issue Aug 23, 2024 · 2 comments
Labels

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Aug 23, 2024

No types from hashes are used in the API (this is correct) however the reexport is still there. This wouldn't be that terrible (just a noise) if ranged version wasn't used. However with ranged versions, if someone depends on the reexport it can have a random dependency breaking randomly. #722 suggests to remove the ranged version but we might want it back again later and it's still noise to reexport.

@apoelstra
Copy link
Member

ACK from me (assuming we have actually eliminated all types from the API). I believe you are correct that this will eliminate all breakage related to the ranged dep.

@Kixunil
Copy link
Collaborator Author

Kixunil commented Aug 23, 2024

assuming we have actually eliminated all types from the API

Yes, I've checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants