Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GetKey for KeyMap #709

Open
LLFourn opened this issue Jul 17, 2024 · 2 comments
Open

Implement GetKey for KeyMap #709

LLFourn opened this issue Jul 17, 2024 · 2 comments

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Jul 17, 2024

See the trait here:

https://docs.rs/bitcoin/latest/bitcoin/psbt/trait.GetKey.html

I think it'd make sense if KeyMap (or something like it) implemented this trait so you could sign PSBTs with the secret keys extracted from a private descriptor.

@apoelstra
Copy link
Member

Oo, neat. Concept ACK. May be a little bit because we are rejigging the relationship between rust-bitcoin and rust-miniscript and I'm unsure what happens to PSBT during that transition.

@tcharding
Copy link
Member

Once bitcoin depends on miniscript hopefully we move psbt_v2 into bitcoin but that shouldn't effect this issue, we can solve this in either miniscript::psbt and port it or in psbt_v2 if we have done the move already. (psbt_v2 contains all the code from psbt::miniscript anyways.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants