feat: Add Cloud Service Links #2551
Conversation
Nikshinde7
requested review from
Anmol-Baranwal,
CBID2,
rupali-codes and
aftabrehan
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
chore
There was a problem hiding this comment.
Hi @Nikshinde7, please do not create a JSON file for each resource, create a single JSON file and add these resources in that file. For more details, kindly follow our contributing guidelines.
Heya @rupali-codes, I think we have a separate JSON file for each resource, so I followed the same approach. However, if we don't want it to be that way, I'll update the PR with the same! Please let me know! Ty!
|
Hey @Nikshinde7, its not for each resource, its just cloud platforms like aws, orcale etc, are very huge so we created a separate subcategory for them, although we would add more resources to it later on. Please summarize the resources you're adding in a single subcategory. |
|
Hey @rupali-codes I have added the necessary changes you mentioned, removed the newly created json files for each category. |
There was a problem hiding this comment.
Hey @Nikshinde7, you don't have to create different subcategories.
As we already have cloud computing category, you just have to create a JSON file in the cloud computing category and name it cloud_computing_platforms.json then add all these resources in that file.
Let me know if you need any help
|
Hey @rupali-codes So I've followed the approach that you shared i.e having an single file for all the subcategories, I hope that resolves it! |
There was a problem hiding this comment.
@Nikshinde7 could you rename the subcategory to platforms for all cloud computing platforms?
|
@rupali-codes I have renamed the subcategories to |
Fixes Issue
Closes #2549
Changes proposed
Screenshots
Note to reviewers
The links to the following services are not working for me. Can you please check it & share the updated links that need to be there, I will update those and the PR should be good for review!