Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: unwanted bottom margin for footer 🙅🏻 🚫 #2051

Closed
4 tasks done
0xabdulkhaliq opened this issue Oct 20, 2023 · 10 comments · Fixed by #2058
Closed
4 tasks done

[BUG]: unwanted bottom margin for footer 🙅🏻 🚫 #2051

0xabdulkhaliq opened this issue Oct 20, 2023 · 10 comments · Fixed by #2058
Assignees
Labels
bug Something isn't working hacktoberfest hacktoberfest2023 priority: medium Modifying an existing feature

Comments

@0xabdulkhaliq
Copy link
Contributor

0xabdulkhaliq commented Oct 20, 2023

Description

  • Footer element consists of unwanted margin values for bottom, which makes bad impression about UI.
  • This bug is applied for both Mobile & Desktop Layouts

Screenshots

MOBILE DESKTOP
MOBILE DESKTOP

Any additional information?

No response

What browser are you seeing the problem on?

Firefox

Checklist

  • I have checked the existing issues
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (optional)
  • I am participating in Hacktoberfest 2023
@0xabdulkhaliq 0xabdulkhaliq added bug Something isn't working priority: medium Modifying an existing feature labels Oct 20, 2023
@0xabdulkhaliq
Copy link
Contributor Author

Hey there @rupali-codes, @CBID2 👋🏻

Please make sure to assign this issue to me to make the work done, Thank You!

@github-actions
Copy link

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
@CBID2 CBID2 removed the 🔒 locked label Oct 20, 2023
Repository owner unlocked this conversation Oct 20, 2023
@CBID2
Copy link
Collaborator

CBID2 commented Oct 20, 2023

It does look quite unattractive. What do you think @Anmol-Baranwal? @rupali-codes?

@rupali-codes
Copy link
Owner

It does look quite unattractive. What do you think @Anmol-Baranwal? @rupali-codes?

Yeah and also kinda distracting,

@0xabdulkhalid you can start working on it, assigning to you!

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
I cannot see this issue, I mean it isn't even scrollable in vertical direction.

Where are you seeing this?

@0xabdulkhaliq
Copy link
Contributor Author

@Anmol-Baranwal Can i know what browser you're using? Because i found this bug on Firefox.

@Anmol-Baranwal
Copy link
Collaborator

@0xabdulkhalid
Then why did you fill chrome in the issue description?

image

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
I've checked, it exists on firefox.

@0xabdulkhaliq
Copy link
Contributor Author

0xabdulkhaliq commented Oct 22, 2023

@0xabdulkhalid Then why did you fill chrome in the issue description?

image

I used Chromium, the issue with that is i didn't updated it for months.
After updating it i can't see this bug there.

I'm extremely sorry for that, It's my fault to test bug at older version of browser.

@Anmol-Baranwal
Copy link
Collaborator

@0xabdulkhalid Then why did you fill chrome in the issue description?
image

I used Chromium, the issue with that is i didn't updated it for months. After updating it i can't see this bug there.

I'm extremely sorry for that, It's my fault to test bug at older version of browser.

No need to say sorry. You are experienced contributor, so that is why I asked. 😅 Will review the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest hacktoberfest2023 priority: medium Modifying an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants