Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'd like to write some documentation for the NJOBS feature in libexec/build-libv8 #33

Open
bretweinraub opened this issue Mar 2, 2022 · 1 comment

Comments

@bretweinraub
Copy link

Usually when I find a useful feature in the code I like to surface this to the documentation.

Specifically this:

https://github.com/rubyjs/libv8-node/blob/master/libexec/build-libv8#L11-L12

I'm happy to write the docs, where should I put them?

README.md doesn't seem to include much about the "guts".... but I'm happy to put it there.

I wonder what the document structure should be. A proposal:

Technical Details

Build Issues

Improving Built Times Using Parallel Compile Jobs

That's just an example.....

@lloeki
Copy link
Collaborator

lloeki commented Mar 7, 2022

I'm happy to write the docs, where should I put them?

README.md doesn't seem to include much about the "guts".... but I'm happy to put it there.

README is fine. As is, the script should be able to detect the number of hardware cores available properly on all unix OSes (linux, darwin, freebsd, solaris) without a third-party tool, and use that as a default for NJOBS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants